Skip to content

Commit 837f1f3

Browse files
committed
fix special case for Cray toolchains in HierarchicalMNS.det_modpath_extensions + enhance test_hierarchical_mns
1 parent ced2fb0 commit 837f1f3

File tree

2 files changed

+7
-2
lines changed

2 files changed

+7
-2
lines changed

easybuild/tools/module_naming_scheme/hierarchical_mns.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -234,8 +234,8 @@ def det_modpath_extensions(self, ec):
234234
paths.append(os.path.join(MPI, tc_comp_name, tc_comp_ver, ec['name'], fullver))
235235

236236
# special case for Cray toolchains
237-
elif modclass == MODULECLASS_TOOLCHAIN and tc_comp_info is None:
238-
paths.append(os.path.join(TOOLCHAIN, ec.toolchain.name, ec.toolchain.version))
237+
elif modclass == MODULECLASS_TOOLCHAIN and tc_comp_info is None and ec.name.startswith('Cray'):
238+
paths.append(os.path.join(TOOLCHAIN, ec.name, ec.version))
239239

240240
return paths
241241

test/framework/module_generator.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1273,6 +1273,11 @@ def test_ec(ecfile, short_modname, mod_subdir, modpath_exts, user_modpath_exts,
12731273
['MPI/intel-CUDA/%s-5.5.22/impi/5.1.2.150' % iccver],
12741274
['MPI/intel-CUDA/%s-5.5.22/impi/5.1.2.150' % iccver],
12751275
['Core']),
1276+
'CrayCCE-5.1.29.eb': ('CrayCCE/5.1.29', 'Core',
1277+
['Toolchain/CrayCCE/5.1.29'],
1278+
['Toolchain/CrayCCE/5.1.29'],
1279+
['Core']),
1280+
'HPL-2.1-CrayCCE-5.1.29.eb': ('HPL/2.1', 'Toolchain/CrayCCE/5.1.29', [], [], ['Core']),
12761281
}
12771282
for ecfile, mns_vals in test_ecs.items():
12781283
test_ec(ecfile, *mns_vals)

0 commit comments

Comments
 (0)