don't use [] as default value for mod_symlink_paths + avoid passing down 'fake' in ModuleGenerator.set_as_default

Author: boegel

easybuild/framework/easyblock.py

@@ -2604,8 +2604,11 @@ def _set_module_as_default(self, fake=False):
             dry_run_msg("Marked %s v%s as default version" % (self.name, version))
         else:
             mod_folderpath = os.path.dirname(self.module_generator.get_module_filepath(fake=fake))
-            mod_symlink_paths = ActiveMNS().det_module_symlink_paths(self.cfg)
-            self.module_generator.set_as_default(mod_folderpath, version, mod_symlink_paths, fake)
+            if fake:
+                mod_symlink_paths = []
+            else:
+                mod_symlink_paths = ActiveMNS().det_module_symlink_paths(self.cfg)
+            self.module_generator.set_as_default(mod_folderpath, version, mod_symlink_paths=mod_symlink_paths)
 
     def cleanup_step(self):
         """

easybuild/tools/module_generator.py

@@ -415,7 +415,7 @@ def set_alias(self, key, value):
         """
         raise NotImplementedError
 
-    def set_as_default(self, module_folder_path, module_version, mod_symlink_paths=[], fake=False):
+    def set_as_default(self, module_folder_path, module_version, mod_symlink_paths=None):
         """
         Set generated module as default module
 
@@ -873,7 +873,7 @@ def set_alias(self, key, value):
         # quotes are needed, to ensure smooth working of EBDEVEL* modulefiles
         return 'set-alias\t%s\t\t%s\n' % (key, quote_str(value, tcl=True))
 
-    def set_as_default(self, module_folder_path, module_version, mod_symlink_paths=[], fake=False):
+    def set_as_default(self, module_folder_path, module_version, mod_symlink_paths=None):
         """
         Create a .version file inside the package module folder in order to set the default version for TMod
 
@@ -889,18 +889,20 @@ def set_as_default(self, module_folder_path, module_version, mod_symlink_paths=[
         write_file(dot_version_path, txt)
 
         # create symlink to .version file in class module folders
-        if not fake:
-            for mod_symlink_path in mod_symlink_paths:
-                module_name = os.path.basename(module_folder_path)
-                class_module_folder = os.path.join(install_path('mod'), mod_symlink_path, module_name)
-                dot_version_link_path = os.path.join(class_module_folder, '.version')
-                if os.path.islink(dot_version_link_path):
-                    link_target = resolve_path(dot_version_link_path)
-                    remove_file(dot_version_link_path)
-                    self.log.info("Removed default version marking from %s.", link_target)
-                elif os.path.exists(dot_version_link_path):
-                    raise EasyBuildError('Found an unexpected file named .version in dir %s' % class_module_folder)
-                symlink(dot_version_path, dot_version_link_path, use_abspath_source=True)
+        if mod_symlink_paths is None:
+            mod_symlink_paths = []
+
+        for mod_symlink_path in mod_symlink_paths:
+            module_name = os.path.basename(module_folder_path)
+            class_module_folder = os.path.join(install_path('mod'), mod_symlink_path, module_name)
+            dot_version_link_path = os.path.join(class_module_folder, '.version')
+            if os.path.islink(dot_version_link_path):
+                link_target = resolve_path(dot_version_link_path)
+                remove_file(dot_version_link_path)
+                self.log.info("Removed default version marking from %s.", link_target)
+            elif os.path.exists(dot_version_link_path):
+                raise EasyBuildError('Found an unexpected file named .version in dir %s' % class_module_folder)
+            symlink(dot_version_path, dot_version_link_path, use_abspath_source=True)
 
     def set_environment(self, key, value, relpath=False):
         """
@@ -1294,7 +1296,7 @@ def set_alias(self, key, value):
         # quotes are needed, to ensure smooth working of EBDEVEL* modulefiles
         return 'set_alias("%s", %s)\n' % (key, quote_str(value))
 
-    def set_as_default(self, module_folder_path, module_version, mod_symlink_paths=[], fake=False):
+    def set_as_default(self, module_folder_path, module_version, mod_symlink_paths=None):
         """
         Create a symlink named 'default' inside the package's module folder in order to set the default module version
 
@@ -1318,11 +1320,13 @@ def create_default_symlink(module_folder_path):
         create_default_symlink(module_folder_path)
 
         # also create symlinks in class module folders
-        if not fake:
-            for mod_symlink_path in mod_symlink_paths:
-                module_name = os.path.basename(module_folder_path)
-                module_folder_path = os.path.join(install_path('mod'), mod_symlink_path, module_name)
-                create_default_symlink(module_folder_path)
+        if mod_symlink_paths is None:
+            mod_symlink_paths = []
+
+        for mod_symlink_path in mod_symlink_paths:
+            module_name = os.path.basename(module_folder_path)
+            module_folder_path = os.path.join(install_path('mod'), mod_symlink_path, module_name)
+            create_default_symlink(module_folder_path)
 
     def set_environment(self, key, value, relpath=False):
         """