Skip to content

Commit a17a42c

Browse files
author
Caspar van Leeuwen
committed
Fix unit tests to accomodate for the difference in the error message that is raised
1 parent e9ec501 commit a17a42c

File tree

1 file changed

+3
-9
lines changed

1 file changed

+3
-9
lines changed

test/framework/toy_build.py

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -3309,8 +3309,7 @@ def assert_cuda_report(missing_cc, additional_cc, missing_ptx, log, stdout=None,
33093309
# This is expected to fail since there is missing device code for CC80
33103310
args = ['--cuda-compute-capabilities=8.0', '--cuda-sanity-check-error-on-fail']
33113311
# We expect this to fail, so first check error, then run again to check output
3312-
error_pattern = r"Sanity check failed: Mismatch between cuda_compute_capabilities and device code in "
3313-
error_pattern += r".*/bin/toy. Missing compute capabilities: 8.0."
3312+
error_pattern = r"Files missing CUDA device code: 1."
33143313
with self.mocked_stdout_stderr():
33153314
self.assertErrorRegex(EasyBuildError, error_pattern, self._test_toy_build, ec_file=toy_ec,
33163315
extra_args=args, raise_error=True)
@@ -3343,9 +3342,7 @@ def assert_cuda_report(missing_cc, additional_cc, missing_ptx, log, stdout=None,
33433342
# This is expected to fail: device code is present, but PTX code for the highest CC (9.0) is missing
33443343
args = ['--cuda-compute-capabilities=9.0', '--cuda-sanity-check-error-on-fail']
33453344
# We expect this to fail, so first check error, then run again to check output
3346-
error_pattern = r"Sanity check failed: Configured highest compute capability was '9\.0', "
3347-
error_pattern += r"but no PTX code for this compute capability was found in '.*/bin/toy' "
3348-
error_pattern += r"\(PTX architectures supported in that file: \['8\.0'\]\)"
3345+
error_pattern = r"Files missing CUDA PTX code: 1"
33493346
with self.mocked_stdout_stderr():
33503347
self.assertErrorRegex(EasyBuildError, error_pattern, self._test_toy_build, ec_file=toy_ec,
33513348
extra_args=args, raise_error=True)
@@ -3379,8 +3376,7 @@ def assert_cuda_report(missing_cc, additional_cc, missing_ptx, log, stdout=None,
33793376
args = ['--cuda-compute-capabilities=9.0', '--cuda-sanity-check-error-on-fail',
33803377
'--cuda-sanity-check-accept-missing-ptx', '--cuda-sanity-check-strict']
33813378
# We expect this to fail, so first check error, then run again to check output
3382-
error_pattern = r"Sanity check failed: Mismatch between cuda_compute_capabilities and device code in "
3383-
error_pattern += r".*/bin/toy. Additional compute capabilities: 7\.0"
3379+
error_pattern = r"Files with additional CUDA device code: 1"
33843380
with self.mocked_stdout_stderr():
33853381
self.assertErrorRegex(EasyBuildError, error_pattern, self._test_toy_build, ec_file=toy_ec,
33863382
extra_args=args, raise_error=True)
@@ -3399,8 +3395,6 @@ def assert_cuda_report(missing_cc, additional_cc, missing_ptx, log, stdout=None,
33993395
args = ['--cuda-compute-capabilities=9.0', '--cuda-sanity-check-error-on-fail',
34003396
'--cuda-sanity-check-accept-missing-ptx', '--cuda-sanity-check-strict']
34013397
# We expect this to succeed, so check output for expected patterns
3402-
error_pattern = r"Sanity check failed: Mismatch between cuda_compute_capabilities and device code in "
3403-
error_pattern += r".*/bin/toy\. Additional compute capabilities: 7\.0"
34043398
with self.mocked_stdout_stderr():
34053399
outtxt = self._test_toy_build(ec_file=toy_whitelist_ec, extra_args=args, raise_error=True, verify=False)
34063400
stdout = self.get_stdout()

0 commit comments

Comments
 (0)