Don't use l as variable names

Author: Flamefire

easybuild/tools/configobj.py

@@ -2025,7 +2025,7 @@ def write(self, outfile=None, section=None):
             # might need to encode
             # NOTE: This will *screw* UTF16, each line will start with the BOM
             if self.encoding:
-                out = [l.encode(self.encoding) for l in out]
+                out = [line.encode(self.encoding) for line in out]
             if (self.BOM and ((self.encoding is None) or
                               (BOM_LIST.get(self.encoding.lower()) == 'utf_8'))):
                 # Add the UTF8 BOM

easybuild/tools/docs.py

@@ -602,7 +602,7 @@ def list_software_rst(software, detailed=False):
 
     def key_to_ref(name):
         """Create a reference label for the specified software name."""
-        return 'list_software_%s_%d' % (name, sum(ord(l) for l in name))
+        return 'list_software_%s_%d' % (name, sum(ord(letter) for letter in name))
 
     letter = None
     sorted_keys = sorted(software.keys(), key=lambda x: x.lower())

easybuild/tools/filetools.py

@@ -2228,8 +2228,8 @@ def diff_files(path1, path2):
     """
     Return unified diff between two files
     """
-    file1_lines = ['%s\n' % l for l in read_file(path1).split('\n')]
-    file2_lines = ['%s\n' % l for l in read_file(path2).split('\n')]
+    file1_lines = ['%s\n' % line for line in read_file(path1).split('\n')]
+    file2_lines = ['%s\n' % line for line in read_file(path2).split('\n')]
     return ''.join(difflib.unified_diff(file1_lines, file2_lines, fromfile=path1, tofile=path2))
 
 

easybuild/tools/include.py

@@ -68,7 +68,7 @@
 import pkgutil
 
 # extend path so Python finds our easyblocks in the subdirectories where they are located
-subdirs = [chr(l) for l in range(ord('a'), ord('z') + 1)] + ['0']
+subdirs = [chr(char) for char in range(ord('a'), ord('z') + 1)] + ['0']
 for subdir in subdirs:
     __path__ = pkgutil.extend_path(__path__, '%s.%s' % (__name__, subdir))
 

easybuild/tools/module_generator.py

@@ -763,7 +763,10 @@ def get_description(self, conflict=True):
             # - 'conflict Compiler/GCC/4.8.2/OpenMPI' for 'Compiler/GCC/4.8.2/OpenMPI/1.6.4'
             lines.extend(['', "conflict %s" % os.path.dirname(self.app.short_mod_name)])
 
-        whatis_lines = ["module-whatis {%s}" % re.sub(r'([{}\[\]])', r'\\\1', l) for l in self._generate_whatis_lines()]
+        whatis_lines = [
+            "module-whatis {%s}" % re.sub(r'([{}\[\]])', r'\\\1', line)
+            for line in self._generate_whatis_lines()
+        ]
         txt += '\n'.join([''] + lines + ['']) % {
             'name': self.app.name,
             'version': self.app.version,

easybuild/tools/run.py

@@ -580,10 +580,10 @@ def parse_log_for_error(txt, regExp=None, stdout=True, msg=None):
     reg = re.compile(regExp, re.I)
 
     res = []
-    for l in txt.split('\n'):
-        r = reg.search(l)
+    for line in txt.split('\n'):
+        r = reg.search(line)
         if r:
-            res.append([l, r.groups()])
+            res.append([line, r.groups()])
             errors_found_in_log += 1
 
     if stdout and res: