Merge pull request #4049 from Flamefire/linter

Fix linting issues

Author: boegel

easybuild/base/fancylogger.py

@@ -380,9 +380,9 @@ def streamLog(self, levelno, data):
 
         def write_and_flush_stream(hdlr, data=None):
             """Write to stream and flush the handler"""
-            if (not hasattr(hdlr, 'stream')) or hdlr.stream is None:
+            if getattr(hdlr, 'stream', None) is None:
                 # no stream or not initialised.
-                raise("write_and_flush_stream failed. No active stream attribute.")
+                raise ValueError("write_and_flush_stream failed. No active stream attribute.")
             if data is not None:
                 hdlr.stream.write(data)
                 hdlr.flush()

easybuild/framework/easyblock.py

@@ -973,7 +973,7 @@ def gen_builddir(self):
         if not self.cfg.get('cleanupoldbuild', False):
             uniq_builddir = builddir
             suff = 0
-            while(os.path.isdir(uniq_builddir)):
+            while os.path.isdir(uniq_builddir):
                 uniq_builddir = "%s.%d" % (builddir, suff)
                 suff += 1
             builddir = uniq_builddir

easybuild/framework/easyconfig/format/version.py

@@ -117,7 +117,7 @@ def __bool__(self):
 
     def is_valid(self):
         """Check if this is a valid VersionOperator. Suffix can be anything."""
-        return not(self.version is None or self.operator is None)
+        return not (self.version is None or self.operator is None)
 
     def set(self, versop_str):
         """

easybuild/tools/filetools.py

@@ -2870,7 +2870,7 @@ def copy_framework_files(paths, target_dir):
         if framework_topdir in dirnames:
             # construct subdirectory by grabbing last entry in dirnames until we hit 'easybuild-framework' dir
             subdirs = []
-            while(dirnames[-1] != framework_topdir):
+            while dirnames[-1] != framework_topdir:
                 subdirs.insert(0, dirnames.pop())
 
             parent_dir = os.path.join(*subdirs) if subdirs else ''

easybuild/tools/modules.py

@@ -462,7 +462,7 @@ def check_module_path(self):
         else:
             # filter out tail of paths that already matches tail of target, to avoid unnecessary 'unuse' commands
             idx = 1
-            while(curr_mod_paths[-idx:] == self.mod_paths[-idx:]):
+            while curr_mod_paths[-idx:] == self.mod_paths[-idx:]:
                 idx += 1
             self.log.debug("Not prepending %d last entries of %s", idx - 1, self.mod_paths)