Skip to content

Commit d7a2e6f

Browse files
authored
Merge pull request #3541 from Micket/cuda_template
Add toolchain deps to template resolution
2 parents a2be0c7 + 6af422a commit d7a2e6f

File tree

2 files changed

+8
-3
lines changed

2 files changed

+8
-3
lines changed

easybuild/framework/easyconfig/templates.py

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,7 @@
8080
TEMPLATE_SOFTWARE_VERSIONS = [
8181
# software name, prefix for *ver and *shortver
8282
('CUDA', 'cuda'),
83+
('CUDAcore', 'cuda'),
8384
('Java', 'java'),
8485
('Perl', 'perl'),
8586
('Python', 'py'),
@@ -238,9 +239,13 @@ def template_constant_dict(config, ignore=None, skip_lower=None, toolchain=None)
238239
# only consider build dependencies when we're actually in iterative mode!
239240
if 'builddependencies' in config.iterate_options:
240241
if config.iterating:
241-
deps += config.get('builddependencies', [])
242+
deps.extend(config.get('builddependencies', []))
242243
else:
243-
deps += config.get('builddependencies', [])
244+
deps.extend(config.get('builddependencies', []))
245+
246+
# Include all toolchain deps (e.g. CUDAcore template in fosscuda)
247+
if config.toolchain.tcdeps is not None:
248+
deps.extend(config.toolchain.tcdeps)
244249

245250
for dep in deps:
246251
if isinstance(dep, dict):

test/framework/robot.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -436,7 +436,7 @@ def test_resolve_dependencies_minimal(self):
436436
" ('SQLite', '3.8.10.2'),",
437437
"]",
438438
# toolchain as list line, for easy modification later;
439-
"toolchain = {'name': 'foss', 'version': '%(version_minor)s018a'}",
439+
"toolchain = {'name': 'foss', 'version': '2018a'}",
440440
]
441441
write_file(barec, '\n'.join(barec_lines))
442442
bar = process_easyconfig(barec)[0]

0 commit comments

Comments
 (0)