Report error even for test reports

Author: Flamefire

easybuild/main.py

@@ -784,9 +784,6 @@ def main(args=None, logfile=None, do_build=None, testing=False, modtool=None, pr
     stop_logging(logfile, logtostdout=options.logtostdout)
     if is_successful:
         cleanup(logfile, eb_tmpdir, testing, silent=options.terse)
-    if options.dump_test_report or options.upload_test_report:
-        # Generation test reports is successful even when software failed to build
-        return EasyBuildExit.SUCCESS
     return EasyBuildExit.SUCCESS if is_successful else EasyBuildExit.ERROR
 
 

test/framework/options.py

@@ -6768,7 +6768,7 @@ def test_keep_going(self):
         with self.mocked_stdout_stderr():
             outtxt, exit_code = self.eb_main(args, do_build=True, raise_error=True,
                                              return_exit_code=True)
-        self.assertEqual(exit_code, 0)  # Creating a test report returns success even on build failure
+        self.assertEqual(exit_code, 1)  # Return failure also when creating a test report
         self.assertRegex(outtxt, r'\[FAILED\] *toy/broken')
         self.assertRegex(outtxt, r'\[SUCCESS\] *toy/working')