Don't fail if generating test reports

Author: Flamefire

easybuild/main.py

@@ -780,6 +780,9 @@ def main(args=None, logfile=None, do_build=None, testing=False, modtool=None, pr
     stop_logging(logfile, logtostdout=options.logtostdout)
     if is_successful:
         cleanup(logfile, eb_tmpdir, testing, silent=options.terse)
+    if options.dump_test_report or options.upload_test_report:
+        # Generation test reports is successful even when software failed to build
+        return EasyBuildExit.SUCCESS
     return EasyBuildExit.SUCCESS if is_successful else EasyBuildExit.ERROR
 
 

test/framework/options.py

@@ -6755,13 +6755,22 @@ def test_keep_going(self):
         self.assertRegex(outtxt, r'\[FAILED\] *toy/broken')
         self.assertRegex(outtxt, r'\[SKIPPED\] *toy/working')
 
+        args.append('--keep-going')
         with self.mocked_stdout_stderr():
-            outtxt, exit_code = self.eb_main(args + ['--keep-going'], do_build=True, raise_error=True,
+            outtxt, exit_code = self.eb_main(args, do_build=True, raise_error=True,
                                              return_exit_code=True)
         self.assertNotEqual(exit_code, 0)
         self.assertRegex(outtxt, r'\[FAILED\] *toy/broken')
         self.assertRegex(outtxt, r'\[SUCCESS\] *toy/working')
 
+        args.append(f"--dump-test-report={os.path.join(tempfile.gettempdir(), 'report.md')}")
+        with self.mocked_stdout_stderr():
+            outtxt, exit_code = self.eb_main(args, do_build=True, raise_error=True,
+                                             return_exit_code=True)
+        self.assertEqual(exit_code, 0)  # Creating a test report returns success even on build failure
+        self.assertRegex(outtxt, r'\[FAILED\] *toy/broken')
+        self.assertRegex(outtxt, r'\[SUCCESS\] *toy/working')
+
     def test_skip_extensions(self):
         """Test use of --skip-extensions."""
         topdir = os.path.abspath(os.path.dirname(__file__))