bump Lmod version to conditional guard around 'extensions' statement in Lua module files to >= 8.2.8 (cfr. TACC/Lmod#428)

Author: boegel

easybuild/tools/module_generator.py

@@ -1048,7 +1048,7 @@ def check_version(self, minimal_version_maj, minimal_version_min, minimal_versio
         :param minimal_version_min: the minor version to check
         :param minimal_version_patch: the patch version to check
         """
-        lmod_version_check_expr = 'convertToCanonical(LmodVersion()) > convertToCanonical("%(maj)s.%(min)s.%(patch)s")'
+        lmod_version_check_expr = 'convertToCanonical(LmodVersion()) >= convertToCanonical("%(maj)s.%(min)s.%(patch)s")'
         return lmod_version_check_expr % {
             'maj': minimal_version_maj,
             'min': minimal_version_min,
@@ -1172,9 +1172,10 @@ def get_description(self, conflict=True):
 
             if extensions_list:
                 extensions_stmt = 'extensions("%s")' % ','.join(['%s' % x for x in extensions_list])
-                # put this behind a Lmod version check as 'extensions' is only (well) supported since Lmod 8.2.7,
-                # see https://lmod.readthedocs.io/en/latest/330_extensions.html#module-extensions
-                lines.extend(['', self.conditional_statement(self.check_version("8", "2", "7"), extensions_stmt)])
+                # put this behind a Lmod version check as 'extensions' is only (well) supported since Lmod 8.2.8,
+                # see https://lmod.readthedocs.io/en/latest/330_extensions.html#module-extensions and
+                # https://github.com/TACC/Lmod/issues/428
+                lines.extend(['', self.conditional_statement(self.check_version("8", "2", "8"), extensions_stmt)])
 
         txt += '\n'.join([''] + lines + ['']) % {
             'name': self.app.name,

test/framework/module_generator.py

@@ -713,12 +713,14 @@ def test_module_extensions(self):
         modgen = self.MODULE_GENERATOR_CLASS(eb)
         desc = modgen.get_description()
 
-        patterns = []
-        if self.MODULE_GENERATOR_CLASS == ModuleGeneratorLua:
-            patterns.append(r'^\s*extensions\("bar/0.0,barbar/0.0,ls,toy/0.0"\)')
+        patterns = [
+            r'^if convertToCanonical\(LmodVersion\(\)\) >= convertToCanonical\("8\.2\.8"\) then\n' +
+            r'\s*extensions\("bar/0.0,barbar/0.0,ls,toy/0.0"\)\nend$',
+        ]
 
         for pattern in patterns:
-            self.assertTrue(re.search(pattern, desc, re.M), "Pattern '%s' found in: %s" % (pattern, desc))
+            regex = re.compile(pattern, re.M)
+            self.assertTrue(regex.search(desc), "Pattern '%s' found in: %s" % (regex.pattern, desc))
 
     def test_prepend_paths(self):
         """Test generating prepend-paths statements."""