Merge pull request #3608 from migueldiascosta/filter_duplicates_in_changes_requested_by

filter duplicates in changes_requested_by

Author: boegel

easybuild/tools/github.py

@@ -1146,7 +1146,7 @@ def not_eligible(msg):
     changes_requested_by = []
     for review in pr_data['reviews']:
         if review['state'] == 'CHANGES_REQUESTED':
-            if review['user']['login'] not in approved_review_by:
+            if review['user']['login'] not in approved_review_by + changes_requested_by:
                 changes_requested_by.append(review['user']['login'])
 
     msg_tmpl = "* no pending change requests: %s"

test/framework/github.py

@@ -657,7 +657,9 @@ def run_check(expected_result=False):
             'number': '1234',
             'merged': False,
             'mergeable_state': 'unknown',
-            'reviews': [{'state': 'CHANGES_REQUESTED', 'user': {'login': 'boegel'}}],
+            'reviews': [{'state': 'CHANGES_REQUESTED', 'user': {'login': 'boegel'}},
+                        # to check that duplicates are filtered
+                        {'state': 'CHANGES_REQUESTED', 'user': {'login': 'boegel'}}],
         }
 
         test_result_warning_template = "* test suite passes: %s => not eligible for merging!"