Merge pull request #3759 from migueldiascosta/missing_patches

warn about potentially missing patches in --new-pr

Author: akesandgren

easybuild/tools/github.py

@@ -1783,6 +1783,14 @@ def new_pr(paths, ecs, title=None, descr=None, commit_msg=None):
     res = new_branch_github(paths, ecs, commit_msg=commit_msg)
     file_info, deleted_paths, _, branch_name, diff_stat, pr_target_repo = res
 
+    for ec, ec_path in zip(file_info['ecs'], file_info['paths_in_repo']):
+        for patch in ec.asdict()['patches']:
+            if isinstance(patch, tuple):
+                patch = patch[0]
+            if patch not in paths['patch_files'] and not os.path.isfile(os.path.join(os.path.dirname(ec_path), patch)):
+                print_warning("new patch file %s, referenced by %s, is not included in this PR" %
+                              (patch, ec.filename()))
+
     new_pr_from_branch(branch_name, title=title, descr=descr, pr_target_repo=pr_target_repo,
                        pr_metadata=(file_info, deleted_paths, diff_stat), commit_msg=commit_msg)