Рефактор + тесты формы авторизации

Вынес модель для логина/пароля в пакет с остальными моделями и написал тесты

Author: easydev991

SwiftUI-WorkoutApp/Libraries/SWModels/Sources/SWModels/LoginCredentials.swift

@@ -0,0 +1,28 @@
+import Foundation
+
+/// Модель для экрана авторизации
+public struct LoginCredentials: Equatable {
+    public var login: String
+    public var password: String
+    let minPasswordSize: Int
+
+    public init(
+        login: String = "",
+        password: String = "",
+        minPasswordSize: Int = Constants.minPasswordSize
+    ) {
+        self.login = login
+        self.password = password
+        self.minPasswordSize = minPasswordSize
+    }
+
+    public var isReady: Bool {
+        !login.isEmpty && password.trueCount >= minPasswordSize
+    }
+
+    public var canRestorePassword: Bool { !login.isEmpty }
+
+    public func canLogIn(isError: Bool, isNetworkConnected: Bool) -> Bool {
+        isReady && !isError && isNetworkConnected
+    }
+}

SwiftUI-WorkoutApp/Libraries/SWModels/Tests/SWModelsTest/LoginCredentialsTests.swift

@@ -0,0 +1,122 @@
+@testable import SWModels
+import Testing
+
+struct LoginCredentialsTests {
+    @Test
+    func testInitializationWithDefaultValues() {
+        let credentials = LoginCredentials()
+        #expect(credentials.login == "")
+        #expect(credentials.password == "")
+        #expect(credentials.minPasswordSize == Constants.minPasswordSize)
+    }
+
+    @Test
+    func testInitializationWithCustomParameters() {
+        let credentials = LoginCredentials(
+            login: "[email protected]",
+            password: "qwerty",
+            minPasswordSize: 5
+        )
+        #expect(credentials.login == "[email protected]")
+        #expect(credentials.password == "qwerty")
+        #expect(credentials.minPasswordSize == 5)
+    }
+
+    // MARK: - isReady
+
+    @Test
+    func testIsReady_AllFieldsEmpty() {
+        let credentials = LoginCredentials()
+        #expect(!credentials.isReady)
+    }
+
+    @Test
+    func testIsReady_LoginNotEmptyPasswordTooShort() {
+        let credentials = LoginCredentials(login: "user", password: "12345")
+        #expect(!credentials.isReady)
+    }
+
+    @Test
+    func testIsReady_ValidLoginAndExactMinPassword() {
+        let credentials = LoginCredentials(login: "user", password: "123456")
+        #expect(credentials.isReady)
+    }
+
+    @Test
+    func testIsReady_PasswordWithSpacesMeetingMinLength() {
+        let credentials = LoginCredentials(login: "user", password: "12 345 6")
+        #expect(credentials.isReady)
+    }
+
+    @Test
+    func testIsReady_PasswordWithSpacesBelowMinLength() {
+        let credentials = LoginCredentials(login: "user", password: "123 45")
+        #expect(!credentials.isReady)
+    }
+
+    @Test
+    func testIsReady_CustomMinPasswordSizeValidation() {
+        let credentials = LoginCredentials(
+            login: "user",
+            password: "1234",
+            minPasswordSize: 4
+        )
+        #expect(credentials.isReady)
+
+        let credentials2 = LoginCredentials(
+            login: "user",
+            password: "123",
+            minPasswordSize: 4
+        )
+        #expect(!credentials2.isReady)
+    }
+
+    // MARK: - canRestorePassword
+
+    @Test
+    func testCanRestorePassword_EmptyLogin() {
+        let credentials = LoginCredentials(login: "")
+        #expect(!credentials.canRestorePassword)
+    }
+
+    @Test
+    func testCanRestorePassword_NonEmptyLogin() {
+        let credentials = LoginCredentials(login: " ")
+        #expect(credentials.canRestorePassword)
+
+        let credentials2 = LoginCredentials(login: "[email protected]")
+        #expect(credentials2.canRestorePassword)
+    }
+
+    // MARK: - canLogIn
+
+    @Test
+    func testCanLogIn_AllConditionsMet() {
+        let credentials = LoginCredentials(login: "user", password: "123456")
+        #expect(credentials.canLogIn(isError: false, isNetworkConnected: true))
+    }
+
+    @Test
+    func testCanLogIn_WhenNotReady() {
+        let credentials = LoginCredentials(login: "user", password: "123")
+        #expect(!credentials.canLogIn(isError: false, isNetworkConnected: true))
+    }
+
+    @Test
+    func testCanLogIn_WithError() {
+        let credentials = LoginCredentials(login: "user", password: "123456")
+        #expect(!credentials.canLogIn(isError: true, isNetworkConnected: true))
+    }
+
+    @Test
+    func testCanLogIn_NoNetwork() {
+        let credentials = LoginCredentials(login: "user", password: "123456")
+        #expect(!credentials.canLogIn(isError: false, isNetworkConnected: false))
+    }
+
+    @Test
+    func testCanLogIn_MultipleIssues() {
+        let credentials = LoginCredentials(login: "user", password: "123")
+        #expect(!credentials.canLogIn(isError: true, isNetworkConnected: false))
+    }
+}

SwiftUI-WorkoutApp/Screens/Settings/LoginScreen.swift

@@ -9,7 +9,7 @@ struct LoginScreen: View {
     @EnvironmentObject private var defaults: DefaultsService
     @Environment(\.isNetworkConnected) private var isNetworkConnected
     @State private var isLoading = false
-    @State private var credentials = Credentials()
+    @State private var credentials = LoginCredentials()
     @State private var resetErrorMessage = ""
     @State private var loginErrorMessage = ""
     @State private var loginTask: Task<Void, Never>?
@@ -40,29 +40,6 @@ struct LoginScreen: View {
 }
 
 private extension LoginScreen {
-    // TODO: написать unit-тесты
-    struct Credentials: Equatable {
-        var login: String
-        var password: String
-        let minPasswordSize: Int
-
-        init(
-            login: String = "",
-            password: String = "",
-            minPasswordSize: Int = Constants.minPasswordSize
-        ) {
-            self.login = login
-            self.password = password
-            self.minPasswordSize = minPasswordSize
-        }
-
-        var isReady: Bool {
-            !login.isEmpty && password.trueCount >= minPasswordSize
-        }
-
-        var canRestorePassword: Bool { !login.isEmpty }
-    }
-
     enum FocusableField: Hashable {
         case username, password
     }
@@ -72,7 +49,7 @@ private extension LoginScreen {
     }
 
     var canLogIn: Bool {
-        credentials.isReady && !isError && isNetworkConnected
+        credentials.canLogIn(isError: isError, isNetworkConnected: isNetworkConnected)
     }
 
     var loginField: some View {