data_replicate will fail with invalid 'times' value when only one column is left in data frame (#654)

* data_replicate will fail with `invalid 'times'` value when only one column is left in data frame
Fixes #652

* prevent simplification

* don's simplify

* data_unique

* ups...

Author: strengejacke

DESCRIPTION

@@ -1,7 +1,7 @@
 Type: Package
 Package: datawizard
 Title: Easy Data Wrangling and Statistical Transformations
-Version: 1.2.0.5
+Version: 1.2.0.6
 Authors@R: c(
     person("Indrajeet", "Patil", , "patilindrajeet.science@gmail.com", role = "aut",
            comment = c(ORCID = "0000-0003-1995-6531")),

NEWS.md

@@ -33,6 +33,9 @@ BUG FIXES
   `values_from` when IDs were not balanced (equally spread across observations)
   (#644).
 
+* Fixed issue in `data_replicate()` when data frame had only one column to
+  replicate (#654).
+
 # datawizard 1.2.0
 
 BREAKING CHANGES

R/data_replicate.R

@@ -98,7 +98,7 @@ data_replicate <- function(data,
   }
 
   # remove rows where "expand" is NA
-  data <- data[!is.na(replicates), ]
+  data <- data[!is.na(replicates), , drop = FALSE]
   replicates <- replicates[!is.na(replicates)]
 
   # fin

R/data_tabulate.R

@@ -519,7 +519,7 @@ as.table.datawizard_table <- function(x, remove_na = TRUE, simplify = FALSE, ver
       insight::format_alert("Removing NA values from frequency table.")
     }
     # remove NA values from the table
-    x <- x[!is.na(x$Value), ]
+    x <- x[!is.na(x$Value), , drop = FALSE]
   }
   # coerce to table
   result <- as.table(stats::setNames(x[["N"]], x$Value))

R/data_to_long.R

@@ -315,7 +315,7 @@ data_to_long <- function(data,
   }
 
   if (values_drop_na) {
-    out <- out[!is.na(out[, values_to]), ]
+    out <- out[!is.na(out[, values_to]), , drop = FALSE]
   }
 
   # add back attributes

R/data_unique.R

@@ -80,7 +80,7 @@ data_unique.data.frame <- function(data,
   ), ]
 
   good.dups <- data_select(good.dups, og.names)
-  out <- data[!duplicated(data$temporary_id2), ]
+  out <- data[!duplicated(data$temporary_id2), , drop = FALSE]
 
 
   if (keep != "first") {

tests/testthat/test-data_replicate.R

@@ -52,3 +52,18 @@ test_that("data_replicate: errors", {
   d$carb[3] <- Inf
   expect_error(data_replicate(d, "carb"), regex = "infinite values")
 })
+
+
+test_that("data_replicate: don't simplify if only one column left", {
+  a <- c(1, 2, 3, 4)
+  b <- c(4, 3, 2, 1)
+  nrtimes <- c(1, 2, 0, 1)
+
+  d <- data.frame(a, b, nrtimes)
+  out <- data_replicate(d, expand = "nrtimes")
+  expect_identical(dim(out), c(4L, 2L))
+
+  d <- data.frame(a, nrtimes)
+  out <- data_replicate(d, expand = "nrtimes")
+  expect_identical(dim(out), c(4L, 1L))
+})