Skip to content

Commit f7ea9ac

Browse files
Copilotstrengejacke
andcommitted
Add TODO comment for overdispersion plot consistency with simulated residuals
Co-authored-by: strengejacke <26301769+strengejacke@users.noreply.github.com>
1 parent bce60d7 commit f7ea9ac

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

R/check_overdispersion.R

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -99,6 +99,10 @@ plot.check_overdisp <- function(x, ...) {
9999
}
100100
}
101101
if (!is.null(model)) {
102+
# TODO: For models that use simulated residuals in check_overdispersion()
103+
# (e.g., Poisson mixed models, zero-inflated models), this still uses
104+
# classical residuals for plotting. Consider using simulated residuals
105+
# for consistency. See #595, #643, #654
102106
x <- .model_diagnostic_overdispersion(model)
103107
class(x) <- c("see_check_overdisp", "data.frame")
104108
attr(x, "colors") <- list(...)$colors

0 commit comments

Comments
 (0)