switch default

Author: strengejacke

R/plot.check_collinearity.R

@@ -82,8 +82,7 @@ plot.see_check_collinearity <- function(
     theme,
     base_size,
     size_axis_title,
-    size_title,
-    default_theme = ggplot2::theme_grey()
+    size_title
   )
 
   ylim <- ceiling(max(x$y, na.rm = TRUE))

R/plot.check_normality.R

@@ -244,8 +244,7 @@ plot.see_check_normality <- function(
     theme,
     base_size,
     size_axis_title,
-    size_title,
-    default_theme = ggplot2::theme_grey()
+    size_title
   )
 
   ggplot2::ggplot(x, ggplot2::aes(x = .data$x)) +
@@ -299,8 +298,7 @@ plot.see_check_normality <- function(
     theme,
     base_size,
     size_axis_title,
-    size_title,
-    default_theme = ggplot2::theme_grey()
+    size_title
   )
 
   # Sample data if too large for performance (issue #420)
@@ -456,8 +454,7 @@ plot.see_check_normality <- function(
     theme,
     base_size,
     size_axis_title,
-    size_title,
-    default_theme = ggplot2::theme_grey()
+    size_title
   )
 
   if (requireNamespace("qqplotr", quietly = TRUE)) {
@@ -544,8 +541,7 @@ plot.see_check_normality <- function(
     theme,
     base_size,
     size_axis_title,
-    size_title,
-    default_theme = ggplot2::theme_grey()
+    size_title
   )
 
   lapply(names(x), function(i) {

R/plot.performance_simres.R

@@ -55,8 +55,7 @@ plot.see_performance_simres <- function(
     theme,
     base_size,
     size_axis_title,
-    size_title,
-    default_theme = ggplot2::theme_grey()
+    size_title
   )
 
   # extract data, if from check_residuals

tests/testthat/test-vdiffr_check_model.R

@@ -71,6 +71,12 @@ test_that("plot.see_check_model() works with themes", {
     fig = plot(performance::check_model(model, check = "linearity")) +
       theme_lucid()
   )
+
+  # Test with modern theme
+  expect_doppelganger_with_seed(
+    title = "check_model_theme_modern_2",
+    fig = plot(performance::check_model(model, theme = theme_modern()))
+  )
 })