Add support for initialConnections, tidy up

Author: rbygrave

ebean-datasource/src/main/java/io/ebean/datasource/pool/PooledConnectionQueue.java

@@ -131,10 +131,10 @@ private int totalConnections() {
     return freeList.size() + busyList.size();
   }
 
-  void createConnections(int count) throws SQLException {
+  void createConnections(int numberToAdd) throws SQLException {
     lock.lock();
     try {
-      for (int i = 0; i < count; i++) {
+      for (int i = 0; i < numberToAdd; i++) {
         freeList.add(pool.createConnectionForQueue(connectionId++));
       }
       notEmpty.signal();
@@ -143,18 +143,6 @@ void createConnections(int count) throws SQLException {
     }
   }
 
-//  void ensureMinimumConnections() throws SQLException {
-//    lock.lock();
-//    try {
-//      int add = minSize - totalConnections();
-//      if (add > 0) {
-//        createConnections(add);
-//      }
-//    } finally {
-//      lock.unlock();
-//    }
-//  }
-
   /**
    * Return a PooledConnection.
    */
@@ -374,7 +362,6 @@ void trim(long maxInactiveMillis, long maxAgeMillis) {
           if (add > 0) {
             createConnections(add);
           }
-          //ensureMinimumConnections();
         } catch (SQLException e) {
           Log.error("Error trying to ensure minimum connections", e);
         }