Refactor invert internal method validateConnection() -> invalidConnection()

Author: rbygrave

ebean-datasource/src/main/java/io/ebean/datasource/pool/ConnectionPool.java

@@ -519,12 +519,12 @@ private boolean testConnection(Connection conn) throws SQLException {
   /**
    * Make sure the connection is still ok to use. If not then remove it from the pool.
    */
-  boolean validateConnection(PooledConnection conn) {
+  boolean invalidConnection(PooledConnection conn) {
     try {
-      return testConnection(conn);
+      return !testConnection(conn);
     } catch (Exception e) {
       Log.warn("Validation test failed on connection:{0} message: {1}", conn.name(), e.getMessage());
-      return false;
+      return true;
     }
   }
 

ebean-datasource/src/main/java/io/ebean/datasource/pool/PooledConnection.java

@@ -386,7 +386,7 @@ public void close() throws SQLException {
       if (failoverToReadOnly) {
         pool.returnConnectionReset(this);
         return;
-      } else if (!pool.validateConnection(this)) {
+      } else if (pool.invalidConnection(this)) {
         // the connection is BAD, remove it, close it and test the pool
         pool.returnConnectionForceClose(this);
         return;

ebean-datasource/src/main/java/io/ebean/datasource/pool/PooledConnectionQueue.java

@@ -205,7 +205,7 @@ private boolean staleEviction(PooledConnection c) {
     if (Log.isLoggable(DEBUG)) {
       Log.debug("stale connection validation millis:{0}", (System.currentTimeMillis() - c.lastUsedTime()));
     }
-    return !pool.validateConnection(c);
+    return pool.invalidConnection(c);
   }
 
   private boolean stale(PooledConnection c) {