Remove ability to modify minConnections at runtime

This was not publically exposed so more removing an unused method.

Author: rbygrave

ebean-datasource/src/main/java/io/ebean/datasource/pool/ConnectionPool.java

@@ -71,7 +71,7 @@ final class ConnectionPool implements DataSourcePool {
   private final AtomicBoolean dataSourceUp = new AtomicBoolean(false);
   private SQLException dataSourceDownReason;
   private final AtomicBoolean inWarningMode = new AtomicBoolean();
-  private int minConnections;
+  private final int minConnections;
   private int maxConnections;
   private int warningSize;
   private final int waitTimeoutMillis;
@@ -197,8 +197,8 @@ private void initialiseConnections() throws SQLException {
     }
 
     final var ro = readOnly ? "readOnly[true] " : "";
-    Log.info("DataSource [{0}] {1}autoCommit[{2}] transIsolation[{3}] min[{4}] max[{5}] in[{6}ms]",
-      name, ro, autoCommit, description(transactionIsolation), minConnections, maxConnections, (System.currentTimeMillis() - start));
+    Log.info("DataSource [{0}] {1}autoCommit[{2}] [{3}] min[{4}] max[{5}] in[{6}ms]",
+      name, ro, autoCommit, description(transactionIsolation), minConnections, maxConnections, (System.currentTimeMillis() - start), validateOnHeartbeat);
   }
 
   /**
@@ -443,22 +443,14 @@ public void setMaxSize(int max) {
   /**
    * Return the max size this pool can grow to.
    */
-  public int getMaxSize() {
+  int getMaxSize() {
     return maxConnections;
   }
 
-  /**
-   * Set the min size this pool should maintain.
-   */
-  public void setMinSize(int min) {
-    queue.setMinSize(min);
-    this.minConnections = min;
-  }
-
   /**
    * Return the min size this pool should maintain.
    */
-  public int getMinSize() {
+  int getMinSize() {
     return minConnections;
   }
 

ebean-datasource/src/main/java/io/ebean/datasource/pool/PooledConnectionQueue.java

@@ -37,9 +37,9 @@ final class PooledConnectionQueue {
   private final long waitTimeoutMillis;
   private final long leakTimeMinutes;
   private final long maxAgeMillis;
+  private final int minSize;
   private int warningSize;
   private int maxSize;
-  private int minSize;
   /**
    * Number of threads in the wait queue.
    */
@@ -115,18 +115,6 @@ PoolStatus status(boolean reset) {
     }
   }
 
-  void setMinSize(int minSize) {
-    lock.lock();
-    try {
-      if (minSize > this.maxSize) {
-        throw new IllegalArgumentException("minSize " + minSize + " > maxSize " + this.maxSize);
-      }
-      this.minSize = minSize;
-    } finally {
-      lock.unlock();
-    }
-  }
-
   void setMaxSize(int maxSize) {
     lock.lock();
     try {