Remove Deprecated methods from DataSourcePool and PoolStatus (migrate to renamed methods)

Author: rbygrave

ebean-datasource-api/src/main/java/io/ebean/datasource/DataSourcePool.java

@@ -47,14 +47,6 @@ static DataSourceBuilder builder() {
    */
   String name();
 
-  /**
-   * @deprecated migrate to {@link #name()}.
-   */
-  @Deprecated
-  default String getName() {
-    return name();
-  }
-
   /**
    * Return the current size of the pool. This includes both busy and idle connections.
    */
@@ -105,27 +97,11 @@ default String getName() {
    */
   PoolStatus status(boolean reset);
 
-  /**
-   * @deprecated migrate to {@link #status(boolean)}.
-   */
-  @Deprecated
-  default PoolStatus getStatus(boolean reset) {
-    return status(reset);
-  }
-
   /**
    * Returns the reason, why the dataSource is down.
    */
   SQLException dataSourceDownReason();
 
-  /**
-   * @deprecated  migrate to {@link #dataSourceDownReason()}
-   */
-  @Deprecated
-  default SQLException getDataSourceDownReason() {
-    return dataSourceDownReason();
-  }
-
   /**
    * Set a new maximum size.
    * <p>

ebean-datasource-api/src/main/java/io/ebean/datasource/PoolStatus.java

@@ -10,105 +10,41 @@ public interface PoolStatus {
    */
   int minSize();
 
-  /**
-   * Deprecated migrate to minSize()
-   */
-  @Deprecated
-  default int getMinSize() {
-    return minSize();
-  }
-
   /**
    * Return the pools maximum size.
    */
   int maxSize();
 
-  /**
-   * Deprecated migrate to maxSize()
-   */
-  @Deprecated
-  default int getMaxSize() {
-    return maxSize();
-  }
-
   /**
    * Return number of free connections.
    */
   int free();
 
-  /**
-   * Deprecated migrate to free()
-   */
-  @Deprecated
-  default int getFree() {
-    return free();
-  }
-
   /**
    * Return number of busy connections.
    */
   int busy();
 
-  /**
-   * Deprecated migrate to busy()
-   */
-  @Deprecated
-  default int getBusy() {
-    return busy();
-  }
-
   /**
    * Return the number of threads waiting for connections.
    */
   int waiting();
 
-  /**
-   * Deprecated migrate to waiting()
-   */
-  @Deprecated
-  default int getWaiting() {
-    return waiting();
-  }
-
   /**
    * Return the busy connection high water mark.
    */
   int highWaterMark();
 
-  /**
-   * Deprecated migrate to waiting()
-   */
-  @Deprecated
-  default int getHighWaterMark() {
-    return highWaterMark();
-  }
-
   /**
    * Return the number of times threads had to wait for connections.
    */
   int waitCount();
 
-  /**
-   * Deprecated migrate to waitCount()
-   */
-  @Deprecated
-  default int getWaitCount() {
-    return waitCount();
-  }
-
   /**
    * Return the hit count against the pool.
    */
   int hitCount();
 
-  /**
-   * Deprecated migrate to hitCount()
-   */
-  @Deprecated
-  default int getHitCount() {
-    return hitCount();
-  }
-
   /**
    * Return the max acquire time in micros.
    */