Skip to content

Commit eea5673

Browse files
committed
No change - Add extra tests only to DataSourceConfigTest
1 parent cb2f649 commit eea5673

File tree

1 file changed

+19
-2
lines changed

1 file changed

+19
-2
lines changed

ebean-datasource-api/src/test/java/io/ebean/datasource/DataSourceConfigTest.java

Lines changed: 19 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -162,13 +162,30 @@ public void defaults() {
162162
}
163163

164164
@Test
165-
public void defaults_someOverride() {
165+
void setDefaults_expect_connectionsDefault() {
166+
DataSourceConfig readOnly = new DataSourceConfig();
167+
readOnly.setDefaults(create());
168+
assertThat(readOnly.getMinConnections()).isEqualTo(1);
169+
assertThat(readOnly.getMaxConnections()).isEqualTo(20);
170+
}
166171

172+
@Test
173+
void setDefaults_when_explicit() {
174+
DataSourceConfig readOnly = new DataSourceConfig();
175+
readOnly.setMinConnections(21);
176+
readOnly.setMaxConnections(22);
177+
readOnly.setDefaults(create());
178+
assertThat(readOnly.getMinConnections()).isEqualTo(21);
179+
assertThat(readOnly.getMaxConnections()).isEqualTo(22);
180+
}
181+
182+
@Test
183+
public void defaults_someOverride() {
167184
DataSourceConfig readOnly = new DataSourceConfig();
168-
readOnly.setMinConnections(3);
169185
readOnly.setUsername("foo2");
170186
readOnly.setUrl("jdbc:postgresql://127.0.0.2:5432/unit");
171187
readOnly.validateOnHeartbeat(false);
188+
readOnly.setMinConnections(3);
172189

173190
DataSourceBuilder configBuilder = create();
174191
DataSourceConfig readOnly2 = readOnly.setDefaults(configBuilder);

0 commit comments

Comments
 (0)