Skip to content

Commit 2795a85

Browse files
authored
Merge pull request #3616 from ebean-orm/feature/lazyLoadBatch-100
Increase default lazyLoadBatchSize from 10 to 100
2 parents 21e50e9 + bd0a3c2 commit 2795a85

File tree

2 files changed

+11
-1
lines changed

2 files changed

+11
-1
lines changed

ebean-api/src/main/java/io/ebean/config/DatabaseConfig.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -251,7 +251,7 @@ public class DatabaseConfig implements DatabaseBuilder.Settings {
251251
/**
252252
* The default batch size for lazy loading
253253
*/
254-
private int lazyLoadBatchSize = 10;
254+
private int lazyLoadBatchSize = 100;
255255

256256
/**
257257
* The default batch size for 'query joins'.

ebean-api/src/test/java/io/ebean/config/DatabaseConfigTest.java

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,8 @@ void testLoadWithProperties() {
7777
props.setProperty("readOnlyDatabase", "true");
7878
props.setProperty("lengthCheck", "ON");
7979
props.setProperty("includeLabelInSql", "false");
80+
props.setProperty("lazyLoadBatchSize", "50");
81+
props.setProperty("queryBatchSize", "60");
8082

8183
props.setProperty("queryPlan.enable", "true");
8284
props.setProperty("queryPlan.thresholdMicros", "10000");
@@ -100,6 +102,8 @@ void testLoadWithProperties() {
100102
assertTrue(settings.readOnlyDatabase());
101103
assertFalse(settings.isIncludeLabelInSql());
102104
assertThat(settings.getLengthCheck()).isEqualTo(LengthCheck.ON);
105+
assertThat(settings.getLazyLoadBatchSize()).isEqualTo(50);
106+
assertThat(settings.getQueryBatchSize()).isEqualTo(60);
103107

104108
assertTrue(settings.isIdGeneratorAutomatic());
105109
assertFalse(settings.getPlatformConfig().isCaseSensitiveCollation());
@@ -179,6 +183,8 @@ void test_defaults() {
179183
assertTrue(config.getPlatformConfig().isCaseSensitiveCollation());
180184
assertTrue(config.isAutoLoadModuleInfo());
181185
assertTrue(config.isLoadModuleInfo());
186+
assertThat(config.getLazyLoadBatchSize()).isEqualTo(100);
187+
assertThat(config.getQueryBatchSize()).isEqualTo(100);
182188

183189
assertFalse(config.isQueryPlanEnable());
184190
assertEquals(Long.MAX_VALUE, config.getQueryPlanThresholdMicros());
@@ -197,6 +203,10 @@ void test_defaults() {
197203
assertTrue(config.isAutoPersistUpdates());
198204
config.setSkipDataSourceCheck(true);
199205
assertTrue(config.skipDataSourceCheck());
206+
config.lazyLoadBatchSize(20);
207+
assertThat(config.getLazyLoadBatchSize()).isEqualTo(20);
208+
config.queryBatchSize(30);
209+
assertThat(config.getQueryBatchSize()).isEqualTo(30);
200210
}
201211

202212
@Test

0 commit comments

Comments
 (0)