Merge pull request #3579 from FOCONIS/rollbac-or-commit-before-close

Rollback/Commit raw connections before close

Author: rbygrave

ebean-api/src/main/java/io/ebean/config/dbplatform/SequenceIdGenerator.java

@@ -157,7 +157,7 @@ protected List<Long> getMoreIds(int requestSize) {
       if (newIds.isEmpty()) {
         throw new PersistenceException("Always expecting more than 1 row from " + sql);
       }
-
+      connection.commit();
       return newIds;
 
     } catch (SQLException e) {

ebean-core/src/main/java/io/ebeaninternal/server/core/DatabasePlatformFactory.java

@@ -77,7 +77,12 @@ private DatabasePlatform byDatabaseName(String dbName) {
    */
   private DatabasePlatform byDataSource(DataSource dataSource) {
     try (Connection connection = dataSource.getConnection()) {
-      return byDatabaseMeta(connection.getMetaData(), connection);
+      DatabasePlatform platform = byDatabaseMeta(connection.getMetaData(), connection);
+      if (!connection.getAutoCommit()) {
+        // we must roll back before close.
+        connection.rollback();
+      }
+      return platform;
     } catch (SQLException ex) {
       throw new PersistenceException(ex);
     }

ebean-core/src/main/java/io/ebeaninternal/server/core/DefaultContainer.java

@@ -262,6 +262,8 @@ private boolean checkDataSource(DatabaseBuilder.Settings config) {
     try (Connection connection = config.getDataSource().getConnection()) {
       if (connection.getAutoCommit()) {
         log.log(WARNING, "DataSource [{0}] has autoCommit defaulting to true!", config.getName());
+      } else {
+        connection.rollback();
       }
       return true;
     } catch (SQLException ex) {

ebean-core/src/main/java/io/ebeaninternal/server/query/CQueryPlanManager.java

@@ -63,6 +63,13 @@ private List<MetaQueryPlan> collectPlans(QueryPlanRequest request) {
       while (req.hasNext()) {
         req.nextCapture();
       }
+      if (!connection.getAutoCommit()) {
+        // CHECKME: commit or rollback here?
+        // arguments for rollback: the collecting should never modify data.
+        // if there are collectors that may copy the plan into tables, it's up to the collector to
+        // commit the transaction.
+        connection.rollback();
+      }
       return req.plans();
     } catch (SQLException e) {
       CoreLog.log.log(ERROR, "Error during query plan collection", e);

ebean-querybean/src/test/java/org/querytest/QCustomerTest.java

@@ -442,6 +442,7 @@ public void usingConnection() throws SQLException {
         .usingConnection(connection)
         .findList();
 
+      connection.rollback();
       assertThat(foo).hasSize(1);
     }
 

ebean-querybean/src/test/resources/application-test.properties

@@ -11,6 +11,7 @@ datasource.default=h2
 datasource.h2.username=sa
 datasource.h2.password=
 datasource.h2.url=jdbc:h2:mem:tests;NON_KEYWORDS=KEY,VALUE
+datasource.h2.closeWithinTxn=fail
 
 datasource.pg.username=sa
 datasource.pg.password=

ebean-test/src/test/java/io/ebean/xtest/dbmigration/DbMigrationTest.java

@@ -220,7 +220,7 @@ private void testVersioning() {
     config.setName(server().name());
     config.loadFromProperties(server().pluginApi().config().getProperties());
     config.setDataSource(server().dataSource());
-    config.setReadOnlyDataSource(server().dataSource());
+    config.setReadOnlyDataSource(server().readOnlyDataSource());
     config.setDdlGenerate(false);
     config.setDdlRun(false);
     config.setRegister(false);
@@ -292,7 +292,7 @@ private void testReservedKeywords() {
     config.setName(server().name());
     config.loadFromProperties(server().pluginApi().config().getProperties());
     config.setDataSource(server().dataSource());
-    config.setReadOnlyDataSource(server().dataSource());
+    config.setReadOnlyDataSource(server().readOnlyDataSource());
     config.setDdlGenerate(false);
     config.setDdlRun(false);
     config.setRegister(false);

ebean-test/src/test/java/io/ebean/xtest/internal/server/rawsql/TestRawSqlBuilder.java

@@ -266,6 +266,7 @@ public void findDuplicateColumnName() throws SQLException {
           }
         }
       }
+      connection.rollback();
     }
   }
 

ebean-test/src/test/java/org/tests/basic/TestQueryUsingConnection.java

@@ -32,6 +32,7 @@ public void usingConnection() throws SQLException {
         .findCount();
 
       assertThat(count).isGreaterThan(0);
+      connection.rollback();
     }
   }
 

ebean-test/src/test/resources/ebean.properties

@@ -76,6 +76,7 @@ datasource.db.databaseDriver=org.h2.Driver
 datasource.h2.username=sa
 datasource.h2.password=
 datasource.h2.url=jdbc:h2:mem:testsMem;DB_CLOSE_ON_EXIT=FALSE;NON_KEYWORDS=KEY,VALUE
+datasource.h2.closeWithinTxn=fail
 datasource.h2.poolListener=org.tests.basic.MyTestDataSourcePoolListener
 #datasource.h2.minConnections=1
 #datasource.h2.maxConnections=25