PGvector

[Ryszard-Trojnacki]

Hi Rob,

I wanted to implement PGvector types, but there are few thing that I'm not sure:

1. As documented in PGVector there is need to register types PGvector.registerTypes(Connection conn). Is there any option (Listener) to include this in Ebean? Or should I create a DriverWrapper for this like it is done in Postgis driver (?). But what if I would like to use PGvector with Postgis?
2. Beyond types, PGvector offers important distance functions which probably should also be implemented. How can I do this for query beans? Is there a possibility to extend query beans for custom types?
3. There are also two index options. This would require an additional annotation or use of Ebean @Index.definition. In the second scenario nothing is needed.

--
Greetings,
Ryszard Trojnacki

[rbygrave]

Register types PGvector.registerTypes(Connection conn)

For ebean-datasource, we could add a service loading mechanism that hooks into when new connections are created. So I had that in mind for this. That will not work for folks not using ebean-datasource though.

distance functions ... Is there a possibility to extend query beans for custom types?

I think we'd need to add a new vector type for query beans.

index options

Ebean @Index does allow any index definition so we already have that required support there.

[Ryszard-Trojnacki]

Sorry for the very big delay, but now I have time and will to implement this.

OK, it seems that the first step to do this, is to extend module ebean-datasource and I would start with this.

As I understant I have to add to: DataSourceConfig and DataSourceBuilder a new option with listener like DataSourcePoolListener is made.

Here I have few questions:

1. Should I add a single listener like DataSourcePoolListener is added or a list (ArrayList<DataSourceConnectionListener>>)?
2. Should I only listen for onCreatedConnection or also other related events? (Not sure if any other events are here)
3. I have read in release notes that there is a option to start with initialConnections. Should this hook/listener also be called on those initial connections or not?
4. Should I name this listener interace DataSourceConnectionListener or DataSourcePoolConnectionListener?