Skip to content

Commit 1cd0f43

Browse files
authored
Fixed expand animation for :class:.ManimBanner (ManimCommunity#3298)
* fixed "a" appearing before shapes * added animation test for ManimBanner * added xelatex to linux pipeline * xelatex -> xetex
1 parent e00c780 commit 1cd0f43

File tree

4 files changed

+15
-2
lines changed

4 files changed

+15
-2
lines changed

.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ jobs:
6868
uses: teatimeguest/setup-texlive-action@v2
6969
with:
7070
cache: true
71-
packages: scheme-basic fontspec inputenc fontenc tipa mathrsfs calligra xcolor standalone preview doublestroke ms everysel setspace rsfs relsize ragged2e fundus-calligra microtype wasysym physics dvisvgm jknapltx wasy cm-super babel-english gnu-freefont mathastext cbfonts-fd
71+
packages: scheme-basic fontspec inputenc fontenc tipa mathrsfs calligra xcolor standalone preview doublestroke ms everysel setspace rsfs relsize ragged2e fundus-calligra microtype wasysym physics dvisvgm jknapltx wasy cm-super babel-english gnu-freefont mathastext cbfonts-fd xetex
7272

7373
- name: Start virtual display (Linux)
7474
if: runner.os == 'Linux'

manim/mobject/logo.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -209,7 +209,7 @@ def slide_and_uncover(mob, alpha):
209209
for letter in mob.anim:
210210
if mob.square.get_center()[0] > letter.get_center()[0]:
211211
letter.set_opacity(1)
212-
self.add(letter)
212+
self.add_to_back(letter)
213213

214214
# Finish animation
215215
if alpha == 1:
Binary file not shown.
Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
from __future__ import annotations
2+
3+
from manim import ManimBanner
4+
from manim.utils.testing.frames_comparison import frames_comparison
5+
6+
__module_test__ = "logo"
7+
8+
9+
@frames_comparison(last_frame=False)
10+
def test_banner(scene):
11+
banner = ManimBanner()
12+
scene.play(banner.create(), run_time=0.5)
13+
scene.play(banner.expand(), run_time=0.5)

0 commit comments

Comments
 (0)