Skip to content

Commit c0aaecb

Browse files
committed
fix exception when there is a missing translation in the resources
fixes #39
1 parent f5219da commit c0aaecb

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

src/main/java/org/kopi/ebics/exception/ReturnCode.java

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@
2222
import java.io.Serializable;
2323
import java.util.HashMap;
2424
import java.util.Map;
25+
import java.util.MissingResourceException;
2526

2627
import org.apache.logging.log4j.LogManager;
2728
import org.apache.logging.log4j.Logger;
@@ -160,16 +161,19 @@ public String toString() {
160161
public static final ReturnCode EBICS_X509_CERTIFICATE_NOT_VALID_YET = create("091209", "EBICS_X509_CERTIFICATE_NOT_VALID_YET");
161162
public static final ReturnCode EBICS_MAX_TRANSACTIONS_EXCEEDED = create("091119", "EBICS_MAX_TRANSACTIONS_EXCEEDED");
162163
public static final ReturnCode EBICS_SIGNATURE_VERIFICATION_FAILED = create("091301", "EBICS_SIGNATURE_VERIFICATION_FAILED");
164+
public static final ReturnCode EBICS_INVALID_ORDER_DATA_FORMAT = create("090004", "EBICS_INVALID_ORDER_DATA_FORMAT");
163165
public static final ReturnCode EBICS_NO_DOWNLOAD_DATA_AVAILABLE = create("090005", "EBICS_NO_DOWNLOAD_DATA_AVAILABLE");
164166
public static final ReturnCode EBICS_ORDERID_ALREADY_EXISTS = create("091115", "EBICS_ORDERID_ALREADY_EXISTS");
165167
public static final ReturnCode EBICS_AUTHORISATION_ORDER_TYPE_FAILED = create("090003", "EBICS_AUTHORISATION_ORDER_TYPE_FAILED");
166168
private static final long serialVersionUID = -497883146384363199L;
167169

168170

169171
private static ReturnCode create(String code, String symbolicName) {
170-
String text = messages.getString(code);
171-
if (text == null) {
172-
throw new NullPointerException("No text for code: " + code);
172+
String text;
173+
try {
174+
text = messages.getString(code);
175+
} catch (MissingResourceException e) {
176+
text = symbolicName;
173177
}
174178
ReturnCode returnCode = new ReturnCode(code, symbolicName, text);
175179
ReturnCode prev = returnCodes.put(code, returnCode);

src/main/java/org/kopi/ebics/messages/Messages.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -65,11 +65,7 @@ public String getString(String key, Object ... arguments) {
6565
* @return the corresponding key value
6666
*/
6767
public String getString(String key) {
68-
try {
6968
return resourceBundle.getString(key);
70-
} catch (MissingResourceException e) {
71-
throw new RuntimeException(e);
72-
}
7369
}
7470

7571
private static ResourceBundle getBundle(String bundleName, Locale locale) {

0 commit comments

Comments
 (0)