Skip to content

Commit bca5b05

Browse files
author
Justin Roberts
committed
set_verion method wasn't necessary
1 parent 867c756 commit bca5b05

File tree

3 files changed

+5
-13
lines changed

3 files changed

+5
-13
lines changed

lib/pardot/authentication.rb

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ module Authentication
33

44
def authenticate
55
resp = post "login", nil, :email => @email, :password => @password, :user_key => @user_key
6-
set_version(parse_version(resp["version"])) if resp && resp["version"]
6+
update_version(resp["version"]) if resp && resp["version"]
77
@api_key = resp && resp["api_key"]
88
end
99

@@ -18,15 +18,11 @@ def reauthenticate
1818

1919
private
2020

21-
def parse_version version
21+
def update_version version
2222
if version.is_a? Array
2323
version = version.last
2424
end
25-
if version.to_i > 3
26-
return version
27-
else
28-
return 3
29-
end
25+
@version = version if version.to_i > 3
3026
end
3127

3228
end

lib/pardot/client.rb

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -31,9 +31,5 @@ def initialize email, password, user_key, version = 3
3131
@format = "simple"
3232
end
3333

34-
def set_version version
35-
@version = version
36-
end
37-
3834
end
3935
end

spec/pardot/http_spec.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ def post object = "foo", path = "/bar", params = {}
7272
describe "getV4" do
7373

7474
def get object = "foo", path = "/bar", params = {}
75-
@client.set_version "4"
75+
@client.version = "4"
7676
@client.get object, path, params
7777
end
7878

@@ -102,7 +102,7 @@ def get object = "foo", path = "/bar", params = {}
102102
describe "postV4" do
103103

104104
def post object = "foo", path = "/bar", params = {}
105-
@client.set_version "4"
105+
@client.version = "4"
106106
@client.post object, path, params
107107
end
108108

0 commit comments

Comments
 (0)