Enh/code revamp 3 (#24)

* Better order for _method usage in _service_request

* Use tuple instead of frozenset with responses that have entities list

* Fix docstring in BaseResponseMeta

Author: ebram96

src/abstract_api/core/bases/_base_response.py

@@ -8,7 +8,7 @@ class BaseResponseMeta(ABC):
     """Base response metadata for Abstract API service response."""
 
     def __init__(self, response: requests.models.Response) -> None:
-        """Initialize a new ResponseMeta."""
+        """Initialize a new BaseResponseMeta."""
         self._http_status: int = response.status_code
         self._body: bytes = response.content
 

src/abstract_api/core/bases/base_service.py

@@ -72,7 +72,8 @@ def _service_request(
         Returns:
             Parsed AbstractAPI's response.
         """
-        if _method.lower() not in ["get", "post"]:
+        _method = _method.lower()
+        if _method not in ["get", "post"]:
             raise ClientRequestError(
                 f"Invalid or not allowed HTTP method '{_method}'"
             )
@@ -82,7 +83,6 @@ def _service_request(
             "url": self._service_url(_action)
         }
 
-        _method = _method.lower()
         if _method == "get":
             request_kwargs["params"] = {"api_key": self._api_key} | params
         else:

src/abstract_api/exchange_rates/_multiple_exchange_rates_response.py

@@ -41,7 +41,7 @@ def _init_response_field(self, field: str, value: Any) -> None:
                 exchange_rates.append(
                     ExchangeRate(currency=currency, rate=rate)
                 )
-            value = frozenset(exchange_rates)
+            value = tuple(exchange_rates)
         super()._init_response_field(field, value)
 
     @property
@@ -50,6 +50,6 @@ def base(self) -> str | None:
         return self._get_response_field("base")
 
     @property
-    def exchange_rates(self) -> frozenset[ExchangeRate] | None:
+    def exchange_rates(self) -> tuple[ExchangeRate] | None:
         """Target currencies exchange rates versus the base currency."""
         return self._get_response_field("exchange_rates")

src/abstract_api/holidays/holidays_response.py

@@ -134,13 +134,13 @@ def _init_response_field(
         holidays = []
         for c in value:
             holidays.append(Holiday(**c))
-        self._holidays = frozenset(holidays)
+        self._holidays = tuple(holidays)
 
     def __init__(self, response: requests.models.Response) -> None:
         """Initializes a new HolidaysResponse."""
         super().__init__(response, RESPONSE_FIELDS, list_response=True)
 
     @property
-    def holidays(self) -> frozenset[Holiday]:
+    def holidays(self) -> tuple[Holiday]:
         """The returned holidays."""
         return self._get_response_field("holidays")

src/abstract_api/vat/vat_categories_response.py

@@ -67,7 +67,7 @@ def _init_response_field(
         categories = []
         for c in value:
             categories.append(Category(**c))
-        self._categories = frozenset(categories)
+        self._categories = tuple(categories)
 
     def __init__(self, response: requests.models.Response) -> None:
         """Initializes a new VATCategoriesResponse."""
@@ -78,6 +78,6 @@ def __init__(self, response: requests.models.Response) -> None:
         )
 
     @property
-    def categories(self) -> frozenset[Category] | None:
+    def categories(self) -> tuple[Category] | None:
         """The returned VAT categories."""
         return self._get_response_field("categories")