🐛 close filehandles

Author: ebullient

src/main/java/dev/ebullient/convert/VersionProvider.java

@@ -1,6 +1,7 @@
 package dev.ebullient.convert;
 
 import java.io.IOException;
+import java.io.InputStream;
 import java.util.Properties;
 
 import dev.ebullient.convert.config.TtrpgConfig;
@@ -11,8 +12,8 @@ public class VersionProvider implements CommandLine.IVersionProvider {
     @Override
     public String[] getVersion() {
         Properties properties = new Properties();
-        try {
-            properties.load(TtrpgConfig.class.getResourceAsStream("/git.properties"));
+        try (InputStream in = TtrpgConfig.class.getResourceAsStream("/git.properties")) {
+            properties.load(in);
             return new String[] {
                     "${COMMAND-FULL-NAME} version " + properties.getProperty("git.build.version"),
                     "Git commit: " + properties.get("git.commit.id.abbrev")

src/main/java/dev/ebullient/convert/io/Tui.java

@@ -484,8 +484,7 @@ private void copyImageResource(ImageRef image, Path targetPath) {
         String sourcePath = image.sourcePath().toString().replace("stream", "");
         targetPath.getParent().toFile().mkdirs();
 
-        try {
-            InputStream in = TtrpgConfig.class.getResourceAsStream(sourcePath);
+        try (InputStream in = TtrpgConfig.class.getResourceAsStream(sourcePath)) {
             Files.copy(in, targetPath, StandardCopyOption.REPLACE_EXISTING);
         } catch (IOException e) {
             errorf("Unable to copy resource. %s", e);
@@ -505,10 +504,8 @@ private void copyRemoteImage(ImageRef image, Path targetPath) {
             return;
         }
 
-        try {
-            Tui.instance().debugf("copy image %s", url);
-
-            ReadableByteChannel readableByteChannel = Channels.newChannel(new URL(url).openStream());
+        Tui.instance().debugf("copy image %s", url);
+        try (ReadableByteChannel readableByteChannel = Channels.newChannel(new URL(url).openStream())) {
             try (FileOutputStream fileOutputStream = new FileOutputStream(targetPath.toFile())) {
                 fileOutputStream.getChannel().transferFrom(readableByteChannel, 0, Long.MAX_VALUE);
             }
@@ -653,10 +650,10 @@ public <T> T readJsonValue(JsonNode node, Class<T> classTarget) {
     }
 
     public static JsonNode readTreeFromResource(String resource) {
-        try {
+        try (InputStream in = TtrpgConfig.class.getResourceAsStream(resource)) {
             return resource.endsWith(".yaml")
-                    ? Tui.yamlMapper().readTree(TtrpgConfig.class.getResourceAsStream(resource))
-                    : Tui.MAPPER.readTree(TtrpgConfig.class.getResourceAsStream(resource));
+                    ? Tui.yamlMapper().readTree(in)
+                    : Tui.MAPPER.readTree(in);
         } catch (IOException | IllegalArgumentException e) {
             Tui.instance.errorf(e, "Unable to read or parse required resource (%s): %s", resource, e.toString());
             return null;