Skip to content

Commit 286f395

Browse files
author
Wliu
authored
Merge pull request atom#479 from StevenTang166/master
Changed const to use the same syntax class as var and let.
2 parents 31b8154 + a96dd63 commit 286f395

File tree

2 files changed

+12
-12
lines changed

2 files changed

+12
-12
lines changed

grammars/javascript.cson

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -879,7 +879,7 @@
879879
'begin': '(?<!\\.)\\b(const)(?!\\s*:)\\b'
880880
'beginCaptures':
881881
'1':
882-
'name': 'storage.modifier.js'
882+
'name': 'storage.type.const.js'
883883
'end': '(\\bof\\b|\\bin\\b)|(;)|(=)|(?<![,{])\\n'
884884
'endCaptures':
885885
'1':

spec/javascript-spec.coffee

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -453,7 +453,7 @@ describe "JavaScript grammar", ->
453453

454454
it "tokenizes variables declared using `const` as constants", ->
455455
{tokens} = grammar.tokenizeLine('const myCoolVar = 42;')
456-
expect(tokens[0]).toEqual value: 'const', scopes: ['source.js', 'storage.modifier.js']
456+
expect(tokens[0]).toEqual value: 'const', scopes: ['source.js', 'storage.type.const.js']
457457
expect(tokens[1]).toEqual value: ' ', scopes: ['source.js']
458458
expect(tokens[2]).toEqual value: 'myCoolVar', scopes: ['source.js', 'constant.other.js']
459459
expect(tokens[3]).toEqual value: ' ', scopes: ['source.js']
@@ -468,7 +468,7 @@ describe "JavaScript grammar", ->
468468
c
469469
if(a)
470470
"""
471-
expect(lines[0][0]).toEqual value: 'const', scopes: ['source.js', 'storage.modifier.js']
471+
expect(lines[0][0]).toEqual value: 'const', scopes: ['source.js', 'storage.type.const.js']
472472
expect(lines[0][1]).toEqual value: ' ', scopes: ['source.js']
473473
expect(lines[0][2]).toEqual value: 'a', scopes: ['source.js', 'constant.other.js']
474474
expect(lines[0][3]).toEqual value: ',', scopes: ['source.js', 'meta.delimiter.object.comma.js']
@@ -487,7 +487,7 @@ describe "JavaScript grammar", ->
487487
c,
488488
} = foo
489489
"""
490-
expect(lines[0][0]).toEqual value: 'const', scopes: ['source.js', 'storage.modifier.js']
490+
expect(lines[0][0]).toEqual value: 'const', scopes: ['source.js', 'storage.type.const.js']
491491
expect(lines[0][1]).toEqual value: ' ', scopes: ['source.js']
492492
expect(lines[0][2]).toEqual value: '{', scopes: ['source.js', 'meta.brace.curly.js']
493493
expect(lines[1][0]).toEqual value: ' ', scopes: ['source.js']
@@ -505,14 +505,14 @@ describe "JavaScript grammar", ->
505505

506506
{tokens} = grammar.tokenizeLine('(const hi);')
507507
expect(tokens[0]).toEqual value: '(', scopes: ['source.js', 'meta.brace.round.js']
508-
expect(tokens[1]).toEqual value: 'const', scopes: ['source.js', 'storage.modifier.js']
508+
expect(tokens[1]).toEqual value: 'const', scopes: ['source.js', 'storage.type.const.js']
509509
expect(tokens[2]).toEqual value: ' ', scopes: ['source.js']
510510
expect(tokens[3]).toEqual value: 'hi', scopes: ['source.js', 'constant.other.js']
511511
expect(tokens[4]).toEqual value: ')', scopes: ['source.js', 'meta.brace.round.js']
512512
expect(tokens[5]).toEqual value: ';', scopes: ['source.js', 'punctuation.terminator.statement.js']
513513

514514
{tokens} = grammar.tokenizeLine('const {first:f,second,...rest} = obj;')
515-
expect(tokens[0]).toEqual value: 'const', scopes: ['source.js', 'storage.modifier.js']
515+
expect(tokens[0]).toEqual value: 'const', scopes: ['source.js', 'storage.type.const.js']
516516
expect(tokens[1]).toEqual value: ' ', scopes: ['source.js']
517517
expect(tokens[2]).toEqual value: '{', scopes: ['source.js', 'meta.brace.curly.js']
518518
expect(tokens[3]).toEqual value: 'first', scopes: ['source.js']
@@ -530,7 +530,7 @@ describe "JavaScript grammar", ->
530530
expect(tokens[15]).toEqual value: ';', scopes: ['source.js', 'punctuation.terminator.statement.js']
531531

532532
{tokens} = grammar.tokenizeLine('const c = /regex/;')
533-
expect(tokens[0]).toEqual value: 'const', scopes: ['source.js', 'storage.modifier.js']
533+
expect(tokens[0]).toEqual value: 'const', scopes: ['source.js', 'storage.type.const.js']
534534
expect(tokens[1]).toEqual value: ' ', scopes: ['source.js']
535535
expect(tokens[2]).toEqual value: 'c', scopes: ['source.js', 'constant.other.js']
536536
expect(tokens[3]).toEqual value: ' ', scopes: ['source.js']
@@ -546,7 +546,7 @@ describe "JavaScript grammar", ->
546546
expect(tokens[0]).toEqual value: 'for', scopes: ['source.js', 'keyword.control.js']
547547
expect(tokens[1]).toEqual value: ' ', scopes: ['source.js']
548548
expect(tokens[2]).toEqual value: '(', scopes: ['source.js', 'meta.brace.round.js']
549-
expect(tokens[3]).toEqual value: 'const', scopes: ['source.js', 'storage.modifier.js']
549+
expect(tokens[3]).toEqual value: 'const', scopes: ['source.js', 'storage.type.const.js']
550550
expect(tokens[4]).toEqual value: ' ', scopes: ['source.js']
551551
expect(tokens[5]).toEqual value: 'elem', scopes: ['source.js', 'constant.other.js']
552552
expect(tokens[6]).toEqual value: ' ', scopes: ['source.js']
@@ -561,12 +561,12 @@ describe "JavaScript grammar", ->
561561
expect(tokens[8]).toEqual value: ' object', scopes: ['source.js']
562562

563563
{tokens} = grammar.tokenizeLine 'const index = 0;'
564-
expect(tokens[0]).toEqual value: 'const', scopes: ['source.js', 'storage.modifier.js']
564+
expect(tokens[0]).toEqual value: 'const', scopes: ['source.js', 'storage.type.const.js']
565565
expect(tokens[2]).toEqual value: 'index', scopes: ['source.js', 'constant.other.js']
566566
expect(tokens[4]).toEqual value: '=', scopes: ['source.js', 'keyword.operator.assignment.js']
567567

568568
{tokens} = grammar.tokenizeLine 'const offset = 0;'
569-
expect(tokens[0]).toEqual value: 'const', scopes: ['source.js', 'storage.modifier.js']
569+
expect(tokens[0]).toEqual value: 'const', scopes: ['source.js', 'storage.type.const.js']
570570
expect(tokens[2]).toEqual value: 'offset', scopes: ['source.js', 'constant.other.js']
571571
expect(tokens[4]).toEqual value: '=', scopes: ['source.js', 'keyword.operator.assignment.js']
572572

@@ -1041,7 +1041,7 @@ describe "JavaScript grammar", ->
10411041
10421042
{tokens} = grammar.tokenizeLine('export const CONSTANT = 0;')
10431043
expect(tokens[0]).toEqual value: 'export', scopes: ['source.js', 'meta.export.js', 'keyword.control.js']
1044-
expect(tokens[2]).toEqual value: 'const', scopes: ['source.js', 'storage.modifier.js']
1044+
expect(tokens[2]).toEqual value: 'const', scopes: ['source.js', 'storage.type.const.js']
10451045
expect(tokens[4]).toEqual value: 'CONSTANT', scopes: ['source.js', 'constant.other.js']
10461046
expect(tokens[6]).toEqual value: '=', scopes: ['source.js', 'keyword.operator.assignment.js']
10471047
@@ -2493,7 +2493,7 @@ describe "JavaScript grammar", ->
24932493
24942494
it "tokenizes comments inside constant definitions", ->
24952495
{tokens} = grammar.tokenizeLine('const a, // comment')
2496-
expect(tokens[0]).toEqual value: 'const', scopes: ['source.js', 'storage.modifier.js']
2496+
expect(tokens[0]).toEqual value: 'const', scopes: ['source.js', 'storage.type.const.js']
24972497
expect(tokens[2]).toEqual value: 'a', scopes: ['source.js', 'constant.other.js']
24982498
expect(tokens[3]).toEqual value: ',', scopes: ['source.js', 'meta.delimiter.object.comma.js']
24992499
expect(tokens[5]).toEqual value: '//', scopes: ['source.js', 'comment.line.double-slash.js', 'punctuation.definition.comment.js']

0 commit comments

Comments
 (0)