forbid patch/post/del on virtual resources (both in functions and in main/index function)

Author: usu

src/Resource.ts

@@ -74,26 +74,14 @@ class Resource implements ResourceInterface {
   }
 
   $post (data: unknown): Promise<ResourceInterface | null> {
-    if (isVirtualResource(this)) {
-      throw new Error('$post is not implemented for virtual resources')
-    }
-
     return this.apiActions.post(this._meta.self, data)
   }
 
   $patch (data: unknown): Promise<ResourceInterface> {
-    if (isVirtualResource(this)) {
-      throw new Error('$patch is not implemented for virtual resources')
-    }
-
     return this.apiActions.patch(this._meta.self, data)
   }
 
   $del (): Promise<string | void> {
-    if (isVirtualResource(this)) {
-      throw new Error('$del is not implemented for virtual resources')
-    }
-
     return this.apiActions.del(this._meta.self)
   }
 

src/index.ts

@@ -69,6 +69,13 @@ function HalJsonVuex (store: Store<Record<string, State>>, axios: AxiosInstance,
       return Promise.reject(new Error(`Could not perform POST, "${uriOrCollection}" is not an entity or URI`))
     }
 
+    if (!isUnknown(uri)) {
+      const entity = get(uri)
+      if (isVirtualResource(entity)) {
+        return Promise.reject(new Error('post is not implemented for virtual resources'))
+      }
+    }
+
     return axios.post(axios.defaults.baseURL + uri, data).then(({ data, status }) => {
       if (status === 204) {
         return null
@@ -262,6 +269,13 @@ function HalJsonVuex (store: Store<Record<string, State>>, axios: AxiosInstance,
     }
     const existsInStore = !isUnknown(uri)
 
+    if (existsInStore) {
+      const entity = get(uri)
+      if (isVirtualResource(entity)) {
+        return Promise.reject(new Error('patch is not implemented for virtual resources'))
+      }
+    }
+
     if (!existsInStore) {
       store.commit('addEmpty', uri)
     }
@@ -320,6 +334,14 @@ function HalJsonVuex (store: Store<Record<string, State>>, axios: AxiosInstance,
       // Can't delete an unknown URI, do nothing
       return Promise.reject(new Error(`Could not perform DELETE, "${uriOrEntity}" is not an entity or URI`))
     }
+
+    if (!isUnknown(uri)) {
+      const entity = get(uri)
+      if (isVirtualResource(entity)) {
+        return Promise.reject(new Error('del is not implemented for virtual resources'))
+      }
+    }
+
     store.commit('deleting', uri)
     return axios.delete(axios.defaults.baseURL + uri).then(
       () => deleted(uri),

tests/apiOperations.spec.js

@@ -648,4 +648,52 @@ describe('Using dollar methods', () => {
     })
     done()
   })
+
+  it('throws error when deleting virtual resource', async done => {
+    // given
+    axiosMock.onGet('http://localhost/camps/1').replyOnce(200, embeddedCollection.serverResponse)
+    const camp = await vm.api.get('/camps/1')._meta.load
+    await letNetworkRequestFinish()
+
+    // when
+    await expect(camp.periods().$del())
+
+    // then
+      .rejects
+      .toThrow('del is not implemented for virtual resources')
+
+    done()
+  })
+
+  it('throws error when posting on virtual resource', async done => {
+    // given
+    axiosMock.onGet('http://localhost/camps/1').replyOnce(200, embeddedCollection.serverResponse)
+    const camp = await vm.api.get('/camps/1')._meta.load
+    await letNetworkRequestFinish()
+
+    // when
+    await expect(camp.periods().$post({}))
+
+    // then
+      .rejects
+      .toThrow('post is not implemented for virtual resources')
+
+    done()
+  })
+
+  it('throws error when patching an virtual resource', async done => {
+    // given
+    axiosMock.onGet('http://localhost/camps/1').replyOnce(200, embeddedCollection.serverResponse)
+    const camp = await vm.api.get('/camps/1')._meta.load
+    await letNetworkRequestFinish()
+
+    // when
+    await expect(camp.periods().$patch([]))
+
+    // then
+      .rejects
+      .toThrow('patch is not implemented for virtual resources')
+
+    done()
+  })
 })