Avoid duplicate reloads

Author: carlobeltrame

CHANGELOG.md

@@ -1,5 +1,8 @@
 ### Unreleased
 
+### 1.2.1
+- Avoid sending a reload request as long as an equal reload request is still ongoing
+
 ### 1.2.0
 - Fixed a bug involving the load promise of embedded collections
 - Added a new method `isUnknown` which can be used to determine whether an URI has never been requested from the API before (except if it was purged in the meantime)

src/index.js

@@ -156,8 +156,9 @@ function HalJsonVuex (store, axios, options) {
   function load (uri, forceReload) {
     const existsInStore = !isUnknown(uri)
 
-    const isLoading = existsInStore && (store.state[opts.apiName][uri]._meta || {}).loading
-    if (isLoading) {
+    const isAlreadyLoading = existsInStore && (store.state[opts.apiName][uri]._meta || {}).loading
+    const isAlreadyReloading = existsInStore && (store.state[opts.apiName][uri]._meta || {}).reloading
+    if (isAlreadyLoading || (forceReload && isAlreadyReloading)) {
       // Reuse the loading entity and load promise that is already waiting for a pending API request
       return store.state[opts.apiName][uri]
     }

tests/store.spec.js

@@ -427,6 +427,46 @@ describe('API store', () => {
         done()
       })
 
+      it('refuses to send out the same reload request again before the ongoing one has completed', async done => {
+        // given
+        axiosMock.onGet('http://localhost/camps/1').replyOnce(200, {
+          id: 1,
+          _links: {
+            self: {
+              href: '/camps/1'
+            }
+          }
+        })
+        axiosMock.onGet('http://localhost/camps/1').replyOnce(200, {
+          id: 2,
+          _links: {
+            self: {
+              href: '/camps/1'
+            }
+          }
+        })
+        axiosMock.onGet('http://localhost/camps/1').replyOnce(200, {
+          id: 3,
+          _links: {
+            self: {
+              href: '/camps/1'
+            }
+          }
+        })
+        const loaded = vm.api.get('/camps/1')
+        await letNetworkRequestFinish()
+        vm.api.reload(loaded)
+
+        // when
+        const load = vm.api.reload(loaded)
+
+        // then
+        await letNetworkRequestFinish()
+        const result = await load
+        expect(result).toMatchObject({ id: 2, _meta: { self: 'http://localhost/camps/1' } })
+        done()
+      })
+
       it('throws when trying to access _meta in an invalid object', () => {
         // given