You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: PR.md
+1-2Lines changed: 1 addition & 2 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -2,10 +2,9 @@
2
2
- prevent circular `referredSemanticId` chains in `DefaultReference` by rejecting self/indirect cycles during assignment
3
3
- add unit tests that cover self and indirect cycles plus happy-path acyclic chains
4
4
- include JUnit dependency in the model module to compile the new tests
5
-
- unblocks SAMM CLI AAS generation (esmf-sdk#802) by preventing the StackOverflow from circular references
6
5
7
6
## Background
8
-
Jackson XML serialization blew up with a StackOverflow when `Reference.referredSemanticId` contained a cycle (e.g., `Reference -> Reference -> same Reference`). The model allowed such graphs because the setter did not guard against cycles. This PR keeps the model acyclic so downstream serializers do not need custom circular-reference handling. This removes the root cause behind SAMM CLI’s infinite recursion during AAS generation (see esmf-sdk#802).
7
+
Jackson XML serialization blew up with a StackOverflow when `Reference.referredSemanticId` contained a cycle (e.g., `Reference -> Reference -> same Reference`). The model allowed such graphs because the setter did not guard against cycles. This PR keeps the model acyclic so downstream serializers do not need custom circular-reference handling.
9
8
10
9
## Implementation Notes
11
10
- cycle detection uses identity (not equals) to avoid false positives from structurally equal references
0 commit comments