Skip to content

Commit 938b12a

Browse files
committed
Revert "Document relation to esmf-sdk#802"
This reverts commit 28a9699.
1 parent 28a9699 commit 938b12a

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

PR.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,9 @@
22
- prevent circular `referredSemanticId` chains in `DefaultReference` by rejecting self/indirect cycles during assignment
33
- add unit tests that cover self and indirect cycles plus happy-path acyclic chains
44
- include JUnit dependency in the model module to compile the new tests
5-
- unblocks SAMM CLI AAS generation (esmf-sdk#802) by preventing the StackOverflow from circular references
65

76
## Background
8-
Jackson XML serialization blew up with a StackOverflow when `Reference.referredSemanticId` contained a cycle (e.g., `Reference -> Reference -> same Reference`). The model allowed such graphs because the setter did not guard against cycles. This PR keeps the model acyclic so downstream serializers do not need custom circular-reference handling. This removes the root cause behind SAMM CLI’s infinite recursion during AAS generation (see esmf-sdk#802).
7+
Jackson XML serialization blew up with a StackOverflow when `Reference.referredSemanticId` contained a cycle (e.g., `Reference -> Reference -> same Reference`). The model allowed such graphs because the setter did not guard against cycles. This PR keeps the model acyclic so downstream serializers do not need custom circular-reference handling.
98

109
## Implementation Notes
1110
- cycle detection uses identity (not equals) to avoid false positives from structurally equal references

0 commit comments

Comments
 (0)