refactor(model): Use the Severity enum in RuleViolation

Change the `RuleViolation` class to use the `Severity` enum as type for
the `severity` property. This ensures that only valid values are used.

A database migration is not required because only valid values were used
before.

Signed-off-by: Martin Nonnenmacher <[email protected]>

Author: mnonnenmacher

dao/src/main/kotlin/tables/runs/evaluator/RuleViolationsTable.kt

@@ -21,6 +21,7 @@ package org.eclipse.apoapsis.ortserver.dao.tables.runs.evaluator
 
 import org.eclipse.apoapsis.ortserver.dao.tables.runs.shared.IdentifierDao
 import org.eclipse.apoapsis.ortserver.dao.tables.runs.shared.IdentifiersTable
+import org.eclipse.apoapsis.ortserver.model.Severity
 import org.eclipse.apoapsis.ortserver.model.runs.OrtRuleViolation
 
 import org.jetbrains.exposed.dao.LongEntity
@@ -37,7 +38,7 @@ object RuleViolationsTable : LongIdTable("rule_violations") {
     val packageIdentifierId = reference("package_identifier_id", IdentifiersTable).nullable()
     val license = text("license").nullable()
     val licenseSource = text("license_source").nullable()
-    val severity = text("severity")
+    val severity = enumerationByName<Severity>("severity", 128)
     val message = text("message")
     val howToFix = text("how_to_fix")
 }

dao/src/testFixtures/kotlin/Fixtures.kt

@@ -52,6 +52,7 @@ import org.eclipse.apoapsis.ortserver.model.NotifierJobConfiguration
 import org.eclipse.apoapsis.ortserver.model.ReporterJobConfiguration
 import org.eclipse.apoapsis.ortserver.model.RepositoryType
 import org.eclipse.apoapsis.ortserver.model.ScannerJobConfiguration
+import org.eclipse.apoapsis.ortserver.model.Severity
 import org.eclipse.apoapsis.ortserver.model.runs.OrtRuleViolation
 
 import org.jetbrains.exposed.sql.Database
@@ -202,7 +203,7 @@ class Fixtures(private val db: Database) {
         license = "license",
         licenseSource = "license source",
         message = "message",
-        severity = "severity",
+        severity = Severity.ERROR,
         howToFix = "how to fix"
     )
 }

model/src/commonMain/kotlin/runs/OrtRuleViolation.kt

@@ -21,13 +21,15 @@ package org.eclipse.apoapsis.ortserver.model.runs
 
 import kotlinx.serialization.Serializable
 
+import org.eclipse.apoapsis.ortserver.model.Severity
+
 @Serializable
 data class OrtRuleViolation(
     val rule: String,
     val packageId: Identifier?,
     val license: String?,
     val licenseSource: String?,
-    val severity: String,
+    val severity: Severity,
     val message: String,
     val howToFix: String
 )

workers/common/src/main/kotlin/common/OrtMappings.kt

@@ -466,7 +466,7 @@ fun OrtRootDependencyIndex.mapToModel() =
 fun OrtRuleViolation.mapToModel() = RuleViolation(
     rule = rule,
     packageId = pkg?.mapToModel(),
-    severity = severity.name,
+    severity = severity.mapToModel(),
     message = message,
     howToFix = howToFix,
     license = license?.toString(),

workers/common/src/main/kotlin/common/OrtServerMappings.kt

@@ -579,7 +579,7 @@ fun RuleViolation.mapToOrt() =
         pkg = packageId?.mapToOrt(),
         license = license?.let { SpdxSingleLicenseExpression.parse(it) },
         licenseSource = licenseSource?.let { LicenseSource.valueOf(it) },
-        severity = OrtSeverity.valueOf(severity),
+        severity = severity.mapToOrt(),
         message = message,
         howToFix = howToFix
     )

workers/common/src/test/kotlin/common/OrtRunServiceTest.kt

@@ -732,7 +732,7 @@ class OrtRunServiceTest : WordSpec({
                         fixtures.identifier,
                         license = "license",
                         licenseSource = "license source",
-                        severity = "ERROR",
+                        severity = Severity.ERROR,
                         message = "the rule is violated",
                         howToFix = "how to fix info"
                     )
@@ -757,7 +757,7 @@ class OrtRunServiceTest : WordSpec({
                         fixtures.identifier,
                         license = "license",
                         licenseSource = "license source",
-                        severity = "ERROR",
+                        severity = Severity.ERROR,
                         message = "the rule is violated",
                         howToFix = howToFix
                     )