Skip to content

Commit 768a6c7

Browse files
committed
refactor(secrets): Do not create unnecessary ListQueryParameters
The default `ListQueryParameters` used by the `listForId` function does not apply a limit, so there is no need to create one that sets the limit to `Integer.MAX_VALUE`. Signed-off-by: Martin Nonnenmacher <[email protected]>
1 parent a0a3294 commit 768a6c7

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

components/secrets/backend/src/main/kotlin/SecretService.kt

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -83,10 +83,9 @@ class SecretService(
8383
suspend fun listForHierarchy(
8484
hierarchy: Hierarchy
8585
): List<Secret> = db.dbQuery {
86-
val parameters = ListQueryParameters(limit = Integer.MAX_VALUE)
87-
val organizationSecrets = secretRepository.listForId(OrganizationId(hierarchy.organization.id), parameters)
88-
val productSecrets = secretRepository.listForId(ProductId(hierarchy.product.id), parameters)
89-
val repositorySecrets = secretRepository.listForId(RepositoryId(hierarchy.repository.id), parameters)
86+
val organizationSecrets = secretRepository.listForId(OrganizationId(hierarchy.organization.id))
87+
val productSecrets = secretRepository.listForId(ProductId(hierarchy.product.id))
88+
val repositorySecrets = secretRepository.listForId(RepositoryId(hierarchy.repository.id))
9089

9190
val secretNames = mutableSetOf<String>()
9291

0 commit comments

Comments
 (0)