feat(services): Do not sync permissions in ProductService

The synchronization of permissions in Keycloak when a product is created
or deleted is no longer needed for the new authorization component. The
dependency to an `AuthorizationService` instance can be dropped.

Signed-off-by: Oliver Heger <[email protected]>

Author: oheger-bosch

core/src/test/kotlin/api/DownloadsRouteIntegrationTest.kt

@@ -71,8 +71,7 @@ class DownloadsRouteIntegrationTest : AbstractIntegrationTest({
             dbExtension.db,
             dbExtension.fixtures.productRepository,
             dbExtension.fixtures.repositoryRepository,
-            dbExtension.fixtures.ortRunRepository,
-            authorizationService
+            dbExtension.fixtures.ortRunRepository
         )
 
         val orgId = organizationService.createOrganization(name = "name", description = "description").id

core/src/test/kotlin/api/OrganizationsRouteIntegrationTest.kt

@@ -140,8 +140,7 @@ class OrganizationsRouteIntegrationTest : AbstractIntegrationTest({
             dbExtension.db,
             dbExtension.fixtures.productRepository,
             dbExtension.fixtures.repositoryRepository,
-            dbExtension.fixtures.ortRunRepository,
-            authorizationService
+            dbExtension.fixtures.ortRunRepository
         )
     }
 

core/src/test/kotlin/api/ProductsRouteIntegrationTest.kt

@@ -160,8 +160,7 @@ class ProductsRouteIntegrationTest : AbstractIntegrationTest({
             dbExtension.db,
             dbExtension.fixtures.productRepository,
             dbExtension.fixtures.repositoryRepository,
-            dbExtension.fixtures.ortRunRepository,
-            authorizationService
+            dbExtension.fixtures.ortRunRepository
         )
 
         orgId = organizationService.createOrganization(name = "name", description = "description").id

core/src/test/kotlin/api/RepositoriesRouteIntegrationTest.kt

@@ -149,8 +149,7 @@ class RepositoriesRouteIntegrationTest : AbstractIntegrationTest({
             dbExtension.db,
             dbExtension.fixtures.productRepository,
             dbExtension.fixtures.repositoryRepository,
-            dbExtension.fixtures.ortRunRepository,
-            authorizationService
+            dbExtension.fixtures.ortRunRepository
         )
 
         ortRunRepository = dbExtension.fixtures.ortRunRepository

core/src/test/kotlin/api/RunsRouteIntegrationTest.kt

@@ -170,8 +170,7 @@ class RunsRouteIntegrationTest : AbstractIntegrationTest({
             dbExtension.db,
             dbExtension.fixtures.productRepository,
             dbExtension.fixtures.repositoryRepository,
-            dbExtension.fixtures.ortRunRepository,
-            authorizationService
+            dbExtension.fixtures.ortRunRepository
         )
 
         ortRunRepository = dbExtension.fixtures.ortRunRepository

services/hierarchy/src/main/kotlin/ProductService.kt

@@ -19,9 +19,7 @@
 
 package org.eclipse.apoapsis.ortserver.services
 
-import org.eclipse.apoapsis.ortserver.components.authorization.keycloak.service.AuthorizationService
 import org.eclipse.apoapsis.ortserver.dao.dbQuery
-import org.eclipse.apoapsis.ortserver.dao.dbQueryCatching
 import org.eclipse.apoapsis.ortserver.dao.repositories.ortrun.OrtRunsTable
 import org.eclipse.apoapsis.ortserver.dao.repositories.repository.RepositoriesTable
 import org.eclipse.apoapsis.ortserver.model.OrtRun
@@ -42,10 +40,6 @@ import org.jetbrains.exposed.sql.SortOrder
 import org.jetbrains.exposed.sql.and
 import org.jetbrains.exposed.sql.max
 
-import org.slf4j.LoggerFactory
-
-private val logger = LoggerFactory.getLogger(OrganizationService::class.java)
-
 /**
  * A service providing functions for working with [products][Product].
  */
@@ -54,7 +48,6 @@ class ProductService(
     private val productRepository: ProductRepository,
     private val repositoryRepository: RepositoryRepository,
     private val ortRunRepository: OrtRunRepository,
-    private val authorizationService: AuthorizationService
 ) {
     /**
      * Create a repository inside a [product][productId].
@@ -64,33 +57,19 @@ class ProductService(
         url: String,
         productId: Long,
         description: String?
-    ): Repository = db.dbQueryCatching {
+    ): Repository = db.dbQuery {
         repositoryRepository.create(type, url, productId, description)
-    }.onSuccess { repository ->
-        runCatching {
-            authorizationService.createRepositoryPermissions(repository.id)
-            authorizationService.createRepositoryRoles(repository.id)
-        }.onFailure { e ->
-            logger.error("Error while creating Keycloak roles for repository '${repository.id}'.", e)
-        }
-    }.getOrThrow()
+    }
 
     /**
      * Delete a [product][productId] with its [repositories][Repository] and [OrtRun]s.
      */
-    suspend fun deleteProduct(productId: Long): Unit = db.dbQueryCatching {
+    suspend fun deleteProduct(productId: Long): Unit = db.dbQuery {
         ortRunRepository.deleteByProduct(productId)
         repositoryRepository.deleteByProduct(productId)
 
         productRepository.delete(productId)
-    }.onSuccess {
-        runCatching {
-            authorizationService.deleteProductPermissions(productId)
-            authorizationService.deleteProductRoles(productId)
-        }.onFailure { e ->
-            logger.error("Error while deleting Keycloak roles for product '$productId'.", e)
-        }
-    }.getOrThrow()
+    }
 
     /**
      * Get a product by [productId]. Returns null if the product is not found.

services/hierarchy/src/test/kotlin/ProductServiceTest.kt

@@ -23,19 +23,11 @@ import io.kotest.core.spec.style.WordSpec
 import io.kotest.matchers.collections.shouldContainExactlyInAnyOrder
 import io.kotest.matchers.shouldBe
 
-import io.mockk.coEvery
-import io.mockk.coVerify
-import io.mockk.just
-import io.mockk.mockk
-import io.mockk.runs
-
-import org.eclipse.apoapsis.ortserver.components.authorization.keycloak.service.AuthorizationService
 import org.eclipse.apoapsis.ortserver.dao.repositories.ortrun.DaoOrtRunRepository
 import org.eclipse.apoapsis.ortserver.dao.repositories.product.DaoProductRepository
 import org.eclipse.apoapsis.ortserver.dao.repositories.repository.DaoRepositoryRepository
 import org.eclipse.apoapsis.ortserver.dao.test.DatabaseTestExtension
 import org.eclipse.apoapsis.ortserver.dao.test.Fixtures
-import org.eclipse.apoapsis.ortserver.model.RepositoryType
 
 import org.jetbrains.exposed.sql.Database
 
@@ -56,48 +48,9 @@ class ProductServiceTest : WordSpec({
         fixtures = dbExtension.fixtures
     }
 
-    "createRepository" should {
-        "create Keycloak permissions" {
-            val authorizationService = mockk<AuthorizationService> {
-                coEvery { createRepositoryPermissions(any()) } just runs
-                coEvery { createRepositoryRoles(any()) } just runs
-            }
-
-            val service =
-                ProductService(db, productRepository, repositoryRepository, ortRunRepository, authorizationService)
-            val repository = service.createRepository(
-                RepositoryType.GIT,
-                "https://example.com/repo.git",
-                fixtures.product.id,
-                "Description"
-            )
-
-            coVerify(exactly = 1) {
-                authorizationService.createRepositoryPermissions(repository.id)
-                authorizationService.createRepositoryRoles(repository.id)
-            }
-        }
-    }
-
     "deleteProduct" should {
-        "delete Keycloak permissions" {
-            val authorizationService = mockk<AuthorizationService> {
-                coEvery { deleteProductPermissions(any()) } just runs
-                coEvery { deleteProductRoles(any()) } just runs
-            }
-
-            val service =
-                ProductService(db, productRepository, repositoryRepository, ortRunRepository, authorizationService)
-            service.deleteProduct(fixtures.product.id)
-
-            coVerify(exactly = 1) {
-                authorizationService.deleteProductPermissions(fixtures.product.id)
-                authorizationService.deleteProductRoles(fixtures.product.id)
-            }
-        }
-
         "delete all repositories associated to this product" {
-            val service = ProductService(db, productRepository, repositoryRepository, ortRunRepository, mockk())
+            val service = ProductService(db, productRepository, repositoryRepository, ortRunRepository)
 
             val product = fixtures.createProduct()
 
@@ -123,7 +76,7 @@ class ProductServiceTest : WordSpec({
 
     "getRepositoryIdsForProduct" should {
         "return IDs for all repositories of a product" {
-            val service = ProductService(db, productRepository, repositoryRepository, ortRunRepository, mockk())
+            val service = ProductService(db, productRepository, repositoryRepository, ortRunRepository)
 
             val prodId = fixtures.createProduct().id