Skip to content

Commit 331a895

Browse files
FriedJannikaaronzi
andauthored
Updates AAS4J to 2.0.0 (#867)
* Updates AAS4J to Snapshot * Fixes problems with order relevant in SMLs * Updates to aas4j 2.0.0 --------- Co-authored-by: Aaron Zielstorff <[email protected]>
1 parent 6307232 commit 331a895

File tree

7 files changed

+14
-14
lines changed

7 files changed

+14
-14
lines changed

basyx.aasxfileserver/basyx.aasxfileserver-backend/src/main/java/org/eclipse/digitaltwin/basyx/aasxfileserver/backend/CrudAASXFileServer.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,7 @@ private String fullyDeletePackage(Package pkg) {
156156
}
157157

158158
private boolean containsShellId(PackageDescription packageDesc, String shellId) {
159-
return packageDesc.getItems().stream().anyMatch(aasId -> aasId.equals(shellId));
159+
return packageDesc.getAasIds().stream().anyMatch(aasId -> aasId.equals(shellId));
160160
}
161161

162162
private Stream<Package> getPackages() {
@@ -167,7 +167,7 @@ private Stream<Package> getPackages() {
167167
private static PackageDescription createPackageDescription(List<String> shellIds, String newPackageId) {
168168
PackageDescription packageDescription = new DefaultPackageDescription();
169169
packageDescription.setPackageId(newPackageId);
170-
packageDescription.setItems(shellIds);
170+
packageDescription.setAasIds(shellIds);
171171

172172
return packageDescription;
173173
}

basyx.aasxfileserver/basyx.aasxfileserver-core/src/test/java/org/eclipse/digitaltwin/basyx/aasxfileserver/core/AASXFileServerSuite.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ public void updateExistingAASXByPackageId() throws IOException {
123123

124124
PackageDescription expectedPackageDescription = new DefaultPackageDescription();
125125
expectedPackageDescription.setPackageId(initialPackageDescription.getPackageId());
126-
expectedPackageDescription.setItems(DummyAASXFileServerFactory.SECOND_SHELL_IDS);
126+
expectedPackageDescription.setAasIds(DummyAASXFileServerFactory.SECOND_SHELL_IDS);
127127

128128
CursorResult<List<PackageDescription>> pagedPackageDescriptions = server.getAllAASXPackageIds("", PaginationInfo.NO_LIMIT);
129129
List<PackageDescription> actualPackageDescription = pagedPackageDescriptions.getResult();

basyx.aasxfileserver/basyx.aasxfileserver-core/src/test/java/org/eclipse/digitaltwin/basyx/aasxfileserver/core/DummyAASXFileServerFactory.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ public static List<PackageDescription> createMultipleDummyAASXPackagesOnServer(A
7878
public static PackageDescription createDummyPackageDescription(String packageId, List<String> shellIds) {
7979
PackageDescription expectedDescription1 = new DefaultPackageDescription();
8080
expectedDescription1.setPackageId(packageId);
81-
expectedDescription1.setItems(shellIds);
81+
expectedDescription1.setAasIds(shellIds);
8282

8383
return expectedDescription1;
8484
}

basyx.submodelservice/basyx.submodelservice-core/src/test/java/org/eclipse/digitaltwin/basyx/submodelservice/DummySubmodelFactory.java

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -195,14 +195,13 @@ private static List<SubmodelElement> getOperationalDataSubmodelElements() {
195195
}
196196

197197
private static List<SubmodelElement> createOperationalDataSubmodelElements() {
198-
ArrayList<SubmodelElement> list = new ArrayList<>();
199-
198+
List<SubmodelElement> list = new ArrayList<>();
200199
SubmodelElement sme1 = createProperty(SUBMODEL_OPERATIONAL_DATA_PROPERTY_ID_SHORT);
201200
SubmodelElement sme2 = createProperty(SUBMODEL_ELEMENT_FIRST_ID_SHORT);
202201
SubmodelElement sme3 = createProperty(SUBMODEL_ELEMENT_SECOND_ID_SHORT);
203202

204203
SubmodelElementCollection submodelElementCollection = new DefaultSubmodelElementCollection();
205-
SubmodelElementList submodelElementList = new DefaultSubmodelElementList();
204+
SubmodelElementList submodelElementList = new DefaultSubmodelElementList.Builder().orderRelevant(true).build();
206205

207206
List<SubmodelElement> submodelElementsCollection = new ArrayList<>();
208207
List<SubmodelElement> submodelElementsList = new ArrayList<>();
@@ -231,8 +230,8 @@ private static void setValuesOfSubmodelElements(SubmodelElement sme2, SubmodelEl
231230

232231
private static SubmodelElementCollection createNestedElementCollection(SubmodelElement sme2) {
233232
SubmodelElementCollection topLevelElementCollection = new DefaultSubmodelElementCollection();
234-
SubmodelElementList submodelElementListInElementCollection = new DefaultSubmodelElementList();
235-
SubmodelElementList submodelElementListInElementList = new DefaultSubmodelElementList();
233+
SubmodelElementList submodelElementListInElementCollection = new DefaultSubmodelElementList.Builder().orderRelevant(true).build();
234+
SubmodelElementList submodelElementListInElementList = new DefaultSubmodelElementList.Builder().orderRelevant(true).build();
236235
SubmodelElementCollection submodelElementCollectionInElementList = new DefaultSubmodelElementCollection();
237236
List<SubmodelElement> submodelElementCollectionInElementListCollection = new ArrayList<>();
238237
List<SubmodelElement> listForSubmodelElementListInElementList = new ArrayList<>();
@@ -272,7 +271,7 @@ private static List<SubmodelElement> createSimpleSubmodelElements() {
272271
smeCollection.setIdShort(SUBMODEL_ELEMENT_COLLECTION_SIMPLE);
273272
smeCollectionValue.add(createProperty(SUBMODEL_ELEMENT_FIRST_ID_SHORT));
274273

275-
SubmodelElementList smeList = new DefaultSubmodelElementList();
274+
SubmodelElementList smeList = new DefaultSubmodelElementList.Builder().orderRelevant(true).build();
276275
smeList.setIdShort(SUBMODEL_ELEMENT_LIST_SIMPLE);
277276
smeListValue.add(createProperty(SUBMODEL_ELEMENT_SECOND_ID_SHORT));
278277

basyx.submodelservice/basyx.submodelservice-core/src/test/java/org/eclipse/digitaltwin/basyx/submodelservice/SubmodelServiceHelper.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -324,6 +324,7 @@ public static SubmodelElementList createSubmodelElementList() {
324324
.build())
325325
.idShort(SUBMODEL_TECHNICAL_DATA_SUBMODEL_ELEMENT_LIST_ID_SHORT)
326326
.category(SUBMODEL_TECHNICAL_DATA_SUBMODEL_ELEMENT_LIST_CATEGORY)
327+
.orderRelevant(true)
327328
.value(Lists.newArrayList(createRangeSubmodelElement(), createPropertySubmodelElement()))
328329
.build();
329330
}

basyx.submodelservice/basyx.submodelservice-core/src/test/java/org/eclipse/digitaltwin/basyx/submodelservice/SubmodelServiceSuite.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,7 @@ public void getHierarchicalSubmodelElementWhenFirstElementIsList() {
146146

147147
List<SubmodelElement> submodelElementsList = new ArrayList<>();
148148

149-
SubmodelElementList submodelElementList = new DefaultSubmodelElementList();
149+
SubmodelElementList submodelElementList = new DefaultSubmodelElementList.Builder().orderRelevant(true).build();
150150
submodelElementList.setIdShort("testList");
151151
List<SubmodelElement> listElements = new ArrayList<>();
152152
Property testProperty = new DefaultProperty.Builder().idShort("propIdShort").category("cat1").value("123").valueType(DataTypeDefXsd.INTEGER).build();
@@ -734,7 +734,7 @@ private String generateNestedIdShortPath() {
734734
}
735735

736736
private DefaultSubmodelElementList createDummySubmodelElementList(String idShort) {
737-
return new DefaultSubmodelElementList.Builder().idShort(idShort).build();
737+
return new DefaultSubmodelElementList.Builder().idShort(idShort).orderRelevant(true).build();
738738
}
739739

740740
private SubmodelElementCollection createDummySubmodelElementCollection(String idShort) {

pom.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@
6969
<docker.target.platforms>linux/amd64, linux/arm64, linux/arm/v7</docker.target.platforms>
7070
<docker.host.port>8081</docker.host.port>
7171
<docker.container.port>8081</docker.container.port>
72-
<aas4j-version>1.0.5</aas4j-version>
72+
<aas4j-version>2.0.0</aas4j-version>
7373
<querydsl-version>5.1.0</querydsl-version>
7474
<jakarta-version>3.2.0</jakarta-version>
7575
</properties>
@@ -84,7 +84,7 @@
8484
</snapshots>
8585
</pluginRepository>
8686
</pluginRepositories>
87-
87+
8888
<build>
8989
<plugins>
9090
<plugin>

0 commit comments

Comments
 (0)