Changes return type for createSubmodelElement

VivekHub97 · VivekHub97 · commit 52e3ab556285 · 2024-10-29T14:12:33.000+01:00
diff --git a/basyx.submodelrepository/basyx.submodelrepository-backend/src/main/java/org/eclipse/digitaltwin/basyx/submodelrepository/backend/CrudSubmodelRepository.java b/basyx.submodelrepository/basyx.submodelrepository-backend/src/main/java/org/eclipse/digitaltwin/basyx/submodelrepository/backend/CrudSubmodelRepository.java
@@ -197,21 +197,23 @@ public void setSubmodelElementValue(String submodelId, String smeIdShort, Submod
 	}
 
 	@Override
-	public void createSubmodelElement(String submodelId, SubmodelElement smElement) {
+	public SubmodelElement createSubmodelElement(String submodelId, SubmodelElement smElement) {
 		SubmodelService submodelService = getSubmodelServiceOrThrow(submodelId);
 
 		submodelService.createSubmodelElement(smElement);
 
 		updateSubmodel(submodelId, submodelService.getSubmodel());
+		return smElement;
 	}
 
 	@Override
-	public void createSubmodelElement(String submodelId, String idShortPath, SubmodelElement smElement) throws ElementDoesNotExistException {
+	public SubmodelElement createSubmodelElement(String submodelId, String idShortPath, SubmodelElement smElement) throws ElementDoesNotExistException {
 		SubmodelService submodelService = getSubmodelServiceOrThrow(submodelId);
 
 		submodelService.createSubmodelElement(idShortPath, smElement);
 
 		updateSubmodel(submodelId, submodelService.getSubmodel());
+		return smElement;
 	}
 
 	@Override
diff --git a/basyx.submodelrepository/basyx.submodelrepository-client/src/main/java/org/eclipse/digitaltwin/basyx/submodelrepository/client/ConnectedSubmodelRepository.java b/basyx.submodelrepository/basyx.submodelrepository-client/src/main/java/org/eclipse/digitaltwin/basyx/submodelrepository/client/ConnectedSubmodelRepository.java
@@ -196,13 +196,13 @@ public void setSubmodelElementValue(String submodelId, String smeIdShort, Submod
 	}
 
 	@Override
-	public void createSubmodelElement(String submodelId, SubmodelElement smElement) {
-		getConnectedSubmodelService(submodelId).createSubmodelElement(smElement);
+	public SubmodelElement createSubmodelElement(String submodelId, SubmodelElement smElement) {
+		return getConnectedSubmodelService(submodelId).createSubmodelElement(smElement);
 	}
 
 	@Override
-	public void createSubmodelElement(String submodelId, String idShortPath, SubmodelElement smElement) throws ElementDoesNotExistException {
-		getConnectedSubmodelService(submodelId).createSubmodelElement(idShortPath, smElement);
+	public SubmodelElement createSubmodelElement(String submodelId, String idShortPath, SubmodelElement smElement) throws ElementDoesNotExistException {
+		return getConnectedSubmodelService(submodelId).createSubmodelElement(idShortPath, smElement);
 	}
 
 	@Override
diff --git a/basyx.submodelrepository/basyx.submodelrepository-core/src/main/java/org/eclipse/digitaltwin/basyx/submodelrepository/SubmodelRepository.java b/basyx.submodelrepository/basyx.submodelrepository-core/src/main/java/org/eclipse/digitaltwin/basyx/submodelrepository/SubmodelRepository.java
@@ -164,7 +164,7 @@ public interface SubmodelRepository {
 	 * @param smElement
 	 *            the SubmodelElement
 	 */
-	public void createSubmodelElement(String submodelId, SubmodelElement smElement);
+	public SubmodelElement createSubmodelElement(String submodelId, SubmodelElement smElement);
 
 	/**
 	 * Creates a nested SubmodelElement
@@ -176,7 +176,7 @@ public interface SubmodelRepository {
 	 * @param smElement
 	 *            the SubmodelElement
 	 */
-	public void createSubmodelElement(String submodelId, String idShortPath, SubmodelElement smElement) throws ElementDoesNotExistException;
+	public SubmodelElement createSubmodelElement(String submodelId, String idShortPath, SubmodelElement smElement) throws ElementDoesNotExistException;
 
 	/**
 	 * Deletes a SubmodelElement
diff --git a/basyx.submodelrepository/basyx.submodelrepository-core/src/test/java/org/eclipse/digitaltwin/basyx/submodelrepository/core/SubmodelRepositorySubmodelServiceWrapper.java b/basyx.submodelrepository/basyx.submodelrepository-core/src/test/java/org/eclipse/digitaltwin/basyx/submodelrepository/core/SubmodelRepositorySubmodelServiceWrapper.java
@@ -86,14 +86,14 @@ public void setSubmodelElementValue(String idShortPath, SubmodelElementValue val
 	}
 
 	@Override
-	public void createSubmodelElement(SubmodelElement submodelElement) {
-		repoApi.createSubmodelElement(submodelId, submodelElement);
+	public SubmodelElement createSubmodelElement(SubmodelElement submodelElement) {
+		return repoApi.createSubmodelElement(submodelId, submodelElement);
 	}
 
 	@Override
-	public void createSubmodelElement(String idShortPath, SubmodelElement submodelElement)
+	public SubmodelElement createSubmodelElement(String idShortPath, SubmodelElement submodelElement)
 			throws ElementDoesNotExistException {
-		repoApi.createSubmodelElement(submodelId, idShortPath, submodelElement);
+		return repoApi.createSubmodelElement(submodelId, idShortPath, submodelElement);
 		
 	}
 
diff --git a/basyx.submodelrepository/basyx.submodelrepository-feature-authorization/src/main/java/org/eclipse/digitaltwin/basyx/submodelrepository/feature/authorization/AuthorizedSubmodelRepository.java b/basyx.submodelrepository/basyx.submodelrepository-feature-authorization/src/main/java/org/eclipse/digitaltwin/basyx/submodelrepository/feature/authorization/AuthorizedSubmodelRepository.java
@@ -155,21 +155,21 @@ public void setSubmodelElementValue(String submodelId, String smeIdShortPath, Su
 	}
 
 	@Override
-	public void createSubmodelElement(String submodelId, SubmodelElement smElement) {
+	public SubmodelElement createSubmodelElement(String submodelId, SubmodelElement smElement) {
 		boolean isAuthorized = permissionResolver.hasPermission(Action.UPDATE, new SubmodelTargetInformation(getIdAsList(submodelId), getIdAsList(ALL_ALLOWED_WILDCARD)));
 
 		throwExceptionIfInsufficientPermission(isAuthorized);
 
-		decorated.createSubmodelElement(submodelId, smElement);
+		return decorated.createSubmodelElement(submodelId, smElement);
 	}
 
 	@Override
-	public void createSubmodelElement(String submodelId, String idShortPath, SubmodelElement smElement) throws ElementDoesNotExistException {
+	public SubmodelElement createSubmodelElement(String submodelId, String idShortPath, SubmodelElement smElement) throws ElementDoesNotExistException {
 		boolean isAuthorized = permissionResolver.hasPermission(Action.UPDATE, new SubmodelTargetInformation(getIdAsList(submodelId), getIdAsList(idShortPath)));
 
 		throwExceptionIfInsufficientPermission(isAuthorized);
 
-		decorated.createSubmodelElement(submodelId, idShortPath, smElement);
+		return decorated.createSubmodelElement(submodelId, idShortPath, smElement);
 	}
 
 	@Override
diff --git a/basyx.submodelrepository/basyx.submodelrepository-feature-mqtt/src/main/java/org/eclipse/digitaltwin/basyx/submodelrepository/feature/mqtt/MqttSubmodelRepository.java b/basyx.submodelrepository/basyx.submodelrepository-feature-mqtt/src/main/java/org/eclipse/digitaltwin/basyx/submodelrepository/feature/mqtt/MqttSubmodelRepository.java
@@ -99,17 +99,19 @@ public void setSubmodelElementValue(String submodelId, String idShortPath, Submo
 	}
 
 	@Override
-	public void createSubmodelElement(String submodelId, SubmodelElement smElement) {
+	public SubmodelElement createSubmodelElement(String submodelId, SubmodelElement smElement) {
 		decorated.createSubmodelElement(submodelId, smElement);
 		SubmodelElement submodelElement = decorated.getSubmodelElement(submodelId, smElement.getIdShort());
 		submodelElementCreated(submodelElement, getName(), submodelId, smElement.getIdShort());
+		return submodelElement;
 	}
 
 	@Override
-	public void createSubmodelElement(String submodelId, String idShortPath, SubmodelElement smElement) throws ElementDoesNotExistException {
+	public SubmodelElement createSubmodelElement(String submodelId, String idShortPath, SubmodelElement smElement) throws ElementDoesNotExistException {
 		decorated.createSubmodelElement(submodelId, idShortPath, smElement);
 		SubmodelElement submodelElement = decorated.getSubmodelElement(submodelId, idShortPath);
 		submodelElementCreated(submodelElement, getName(), submodelId, idShortPath);
+		return submodelElement;
 	}
 	
 	@Override
diff --git a/basyx.submodelrepository/basyx.submodelrepository-feature-operation-delegation/src/main/java/org/eclipse/digitaltwin/basyx/submodelrepository/feature/operation/delegation/OperationDelegationSubmodelRepository.java b/basyx.submodelrepository/basyx.submodelrepository-feature-operation-delegation/src/main/java/org/eclipse/digitaltwin/basyx/submodelrepository/feature/operation/delegation/OperationDelegationSubmodelRepository.java
@@ -117,13 +117,13 @@ public void setSubmodelElementValue(String submodelId, String smeIdShort, Submod
 	}
 
 	@Override
-	public void createSubmodelElement(String submodelId, SubmodelElement smElement) {
-		decorated.createSubmodelElement(submodelId, smElement);
+	public SubmodelElement createSubmodelElement(String submodelId, SubmodelElement smElement) {
+		return decorated.createSubmodelElement(submodelId, smElement);
 	}
 
 	@Override
-	public void createSubmodelElement(String submodelId, String idShortPath, SubmodelElement smElement) throws ElementDoesNotExistException {
-		decorated.createSubmodelElement(submodelId, idShortPath, smElement);
+	public SubmodelElement createSubmodelElement(String submodelId, String idShortPath, SubmodelElement smElement) throws ElementDoesNotExistException {
+		return decorated.createSubmodelElement(submodelId, idShortPath, smElement);
 	}
 
 	@Override
diff --git a/basyx.submodelrepository/basyx.submodelrepository-feature-registry-integration/src/main/java/org/eclipse/digitaltwin/basyx/submodelrepository/feature/registry/integration/RegistryIntegrationSubmodelRepository.java b/basyx.submodelrepository/basyx.submodelrepository-feature-registry-integration/src/main/java/org/eclipse/digitaltwin/basyx/submodelrepository/feature/registry/integration/RegistryIntegrationSubmodelRepository.java
@@ -134,13 +134,13 @@ public void setSubmodelElementValue(String submodelId, String idShortPath, Submo
 	}
 
 	@Override
-	public void createSubmodelElement(String submodelId, SubmodelElement submodelElement) {
-		decorated.createSubmodelElement(submodelId, submodelElement);
+	public SubmodelElement createSubmodelElement(String submodelId, SubmodelElement submodelElement) {
+		return decorated.createSubmodelElement(submodelId, submodelElement);
 	}
 
 	@Override
-	public void createSubmodelElement(String submodelId, String idShortPath, SubmodelElement submodelElement) throws ElementDoesNotExistException {
-		decorated.createSubmodelElement(submodelId, idShortPath, submodelElement);
+	public SubmodelElement createSubmodelElement(String submodelId, String idShortPath, SubmodelElement submodelElement) throws ElementDoesNotExistException {
+		return decorated.createSubmodelElement(submodelId, idShortPath, submodelElement);
 	}
 	
 	@Override
diff --git a/basyx.submodelrepository/basyx.submodelrepository-http/src/main/java/org/eclipse/digitaltwin/basyx/submodelrepository/http/SubmodelRepositoryApiHTTPController.java b/basyx.submodelrepository/basyx.submodelrepository-http/src/main/java/org/eclipse/digitaltwin/basyx/submodelrepository/http/SubmodelRepositoryApiHTTPController.java
@@ -175,14 +175,14 @@ public ResponseEntity<SubmodelElement> getSubmodelElementByPathSubmodelRepo(Base
 
 	@Override
 	public ResponseEntity<SubmodelElement> postSubmodelElementByPathSubmodelRepo(Base64UrlEncodedIdentifier submodelIdentifier, String idShortPath, @Valid SubmodelElement body, @Valid String level, @Valid String extent) {
-		repository.createSubmodelElement(submodelIdentifier.getIdentifier(), idShortPath, body);
-		return new ResponseEntity<SubmodelElement>(HttpStatus.CREATED);
+		SubmodelElement createdSME = repository.createSubmodelElement(submodelIdentifier.getIdentifier(), idShortPath, body);
+		return new ResponseEntity<SubmodelElement>(createdSME, HttpStatus.CREATED);
 	}
 
 	@Override
 	public ResponseEntity<SubmodelElement> postSubmodelElementSubmodelRepo(Base64UrlEncodedIdentifier submodelIdentifier, @Valid SubmodelElement body) {
-		repository.createSubmodelElement(submodelIdentifier.getIdentifier(), body);
-		return new ResponseEntity<SubmodelElement>(body, HttpStatus.CREATED);
+	    SubmodelElement createdSME = repository.createSubmodelElement(submodelIdentifier.getIdentifier(), body);
+	    return new ResponseEntity<SubmodelElement>(createdSME, HttpStatus.CREATED);
 	}
 
 	@Override
diff --git a/basyx.submodelservice/basyx.submodelservice-backend-inmemory/src/main/java/org/eclipse/digitaltwin/basyx/submodelservice/InMemorySubmodelService.java b/basyx.submodelservice/basyx.submodelservice-backend-inmemory/src/main/java/org/eclipse/digitaltwin/basyx/submodelservice/InMemorySubmodelService.java
@@ -123,12 +123,13 @@ public void setSubmodelElementValue(String idShort, SubmodelElementValue value)
 	}
 
 	@Override
-	public void createSubmodelElement(SubmodelElement submodelElement) throws CollidingIdentifierException {
+	public SubmodelElement createSubmodelElement(SubmodelElement submodelElement) throws CollidingIdentifierException {
 		throwIfSubmodelElementExists(submodelElement.getIdShort());
 
 		List<SubmodelElement> smElements = submodel.getSubmodelElements();
 		smElements.add(submodelElement);
 		submodel.setSubmodelElements(smElements);
+		return submodelElement;
 	}
 
 	private void throwIfSubmodelElementExists(String submodelElementId) {
@@ -141,7 +142,7 @@ private void throwIfSubmodelElementExists(String submodelElementId) {
 	}
 
 	@Override
-	public void createSubmodelElement(String idShortPath, SubmodelElement submodelElement) throws ElementDoesNotExistException, CollidingIdentifierException {
+	public SubmodelElement createSubmodelElement(String idShortPath, SubmodelElement submodelElement) throws ElementDoesNotExistException, CollidingIdentifierException {
 		throwIfSubmodelElementExists(getFullIdShortPath(idShortPath, submodelElement.getIdShort()));
 
 		SubmodelElement parentSme = parser.getSubmodelElementFromIdShortPath(idShortPath);
@@ -150,15 +151,14 @@ public void createSubmodelElement(String idShortPath, SubmodelElement submodelEl
 			List<SubmodelElement> submodelElements = list.getValue();
 			submodelElements.add(submodelElement);
 			list.setValue(submodelElements);
-			return;
 		}
 		if (parentSme instanceof SubmodelElementCollection) {
 			SubmodelElementCollection collection = (SubmodelElementCollection) parentSme;
 			List<SubmodelElement> submodelElements = collection.getValue();
 			submodelElements.add(submodelElement);
 			collection.setValue(submodelElements);
-			return;
 		}
+		return submodelElement;
 	}
 
 	@Override
diff --git a/basyx.submodelservice/basyx.submodelservice-backend-mongodb/src/main/java/org/eclipse/digitaltwin/basyx/submodelservice/MongoDBSubmodelService.java b/basyx.submodelservice/basyx.submodelservice-backend-mongodb/src/main/java/org/eclipse/digitaltwin/basyx/submodelservice/MongoDBSubmodelService.java
@@ -103,19 +103,21 @@ public void setSubmodelElementValue(String idShortPath, SubmodelElementValue val
 	}
 
 	@Override
-	public void createSubmodelElement(SubmodelElement submodelElement) {
+	public SubmodelElement createSubmodelElement(SubmodelElement submodelElement) {
 		InMemorySubmodelService inMemorySubmodelService = getInMemorySubmodelService();
 		inMemorySubmodelService.createSubmodelElement(submodelElement);
 		Submodel submodel = inMemorySubmodelService.getSubmodel();
 		crudRepository.save(submodel);
+		return submodelElement;
 	}
 
 	@Override
-	public void createSubmodelElement(String idShortPath, SubmodelElement submodelElement) throws ElementDoesNotExistException {
+	public SubmodelElement createSubmodelElement(String idShortPath, SubmodelElement submodelElement) throws ElementDoesNotExistException {
 		InMemorySubmodelService inMemorySubmodelService = getInMemorySubmodelService();
 		inMemorySubmodelService.createSubmodelElement(idShortPath, submodelElement);
 		Submodel submodel = inMemorySubmodelService.getSubmodel();
 		crudRepository.save(submodel);
+		return submodelElement;
 
 	}
 
diff --git a/basyx.submodelservice/basyx.submodelservice-client/src/main/java/org/eclipse/digitaltwin/basyx/submodelservice/client/ConnectedSubmodelService.java b/basyx.submodelservice/basyx.submodelservice-client/src/main/java/org/eclipse/digitaltwin/basyx/submodelservice/client/ConnectedSubmodelService.java
@@ -113,14 +113,14 @@ public void setSubmodelElementValue(String idShortPath, SubmodelElementValue val
 	}
 
 	@Override
-	public void createSubmodelElement(SubmodelElement submodelElement) {
-		serviceApi.postSubmodelElement(submodelElement);
+	public SubmodelElement createSubmodelElement(SubmodelElement submodelElement) {
+		return serviceApi.postSubmodelElement(submodelElement);
 	}
 
 	@Override
-	public void createSubmodelElement(String idShortPath, SubmodelElement submodelElement) throws ElementDoesNotExistException {
+	public SubmodelElement createSubmodelElement(String idShortPath, SubmodelElement submodelElement) throws ElementDoesNotExistException {
 		try {
-			serviceApi.postSubmodelElementByPath(idShortPath, submodelElement);
+			return serviceApi.postSubmodelElementByPath(idShortPath, submodelElement);
 		} catch (ApiException e) {
 			throw mapExceptionSubmodelElementAccess(idShortPath, e);
 		}
diff --git a/basyx.submodelservice/basyx.submodelservice-core/src/main/java/org/eclipse/digitaltwin/basyx/submodelservice/SubmodelService.java b/basyx.submodelservice/basyx.submodelservice-core/src/main/java/org/eclipse/digitaltwin/basyx/submodelservice/SubmodelService.java
@@ -90,9 +90,10 @@ public interface SubmodelService {
 
 	/**
 	 * Creates a Submodel Element
+	 * @return 
 	 * 
 	 */
-	public void createSubmodelElement(SubmodelElement submodelElement);
+	public SubmodelElement createSubmodelElement(SubmodelElement submodelElement);
 
 	/**
 	 * Create a nested submodel element
@@ -101,10 +102,11 @@ public interface SubmodelService {
 	 *            the SubmodelElement IdShortPath
 	 * @param submodelElement
 	 *            the submodel element to be created
+	 * @return 
 	 * @throws ElementDoesNotExistException
 	 *             If the submodel element defined in the path does not exist
 	 */
-	public void createSubmodelElement(String idShortPath, SubmodelElement submodelElement) throws ElementDoesNotExistException;
+	public SubmodelElement createSubmodelElement(String idShortPath, SubmodelElement submodelElement) throws ElementDoesNotExistException;
 	
 	/**
 	 * Updates a submodel element
diff --git a/basyx.submodelservice/basyx.submodelservice-feature-mqtt/src/main/java/org/eclipse/digitaltwin/basyx/submodelservice/feature/mqtt/MqttSubmodelService.java b/basyx.submodelservice/basyx.submodelservice-feature-mqtt/src/main/java/org/eclipse/digitaltwin/basyx/submodelservice/feature/mqtt/MqttSubmodelService.java
@@ -93,19 +93,21 @@ public void setSubmodelElementValue(String idShortPath, SubmodelElementValue val
 	}
 
 	@Override
-	public void createSubmodelElement(SubmodelElement submodelElement) {
+	public SubmodelElement createSubmodelElement(SubmodelElement submodelElement) {
 		decorated.createSubmodelElement(submodelElement);
 		SubmodelElement smElement = decorated.getSubmodelElement(submodelElement.getIdShort());
 		submodelElementCreated(submodelElement, smElement.getIdShort());
+		return smElement;
 	}
 
 	@Override
-	public void createSubmodelElement(String idShortPath, SubmodelElement submodelElement) throws ElementDoesNotExistException {
+	public SubmodelElement createSubmodelElement(String idShortPath, SubmodelElement submodelElement) throws ElementDoesNotExistException {
 
 		decorated.createSubmodelElement(idShortPath, submodelElement);
 
 		SubmodelElement smElement = decorated.getSubmodelElement(submodelElement.getIdShort());
 		submodelElementCreated(smElement, idShortPath);
+		return smElement;
 	}
 
 	@Override
diff --git a/basyx.submodelservice/basyx.submodelservice-http/src/main/java/org/eclipse/digitaltwin/basyx/submodelservice/http/SubmodelServiceHTTPApiController.java b/basyx.submodelservice/basyx.submodelservice-http/src/main/java/org/eclipse/digitaltwin/basyx/submodelservice/http/SubmodelServiceHTTPApiController.java
@@ -198,16 +198,16 @@ public ResponseEntity<Void> patchSubmodelElementByPathValueOnly(
 	public ResponseEntity<SubmodelElement> postSubmodelElement(@Parameter(in = ParameterIn.DEFAULT, description = "Requested submodel element", required = true, schema = @Schema()) @Valid @RequestBody SubmodelElement body,
 			@Parameter(in = ParameterIn.QUERY, description = "Determines the structural depth of the respective resource content", schema = @Schema(allowableValues = { "deep",
 					"core" }, defaultValue = "deep")) @Valid @RequestParam(value = "level", required = false, defaultValue = "deep") String level) {
-		service.createSubmodelElement(body);
-		return new ResponseEntity<SubmodelElement>(body, HttpStatus.CREATED);
+		SubmodelElement createdSME = service.createSubmodelElement(body);
+		return new ResponseEntity<SubmodelElement>(createdSME, HttpStatus.CREATED);
 	}
 
 	@Override
 	public ResponseEntity<SubmodelElement> postSubmodelElementByPath(
 			@Parameter(in = ParameterIn.PATH, description = "IdShort path to the submodel element (dot-separated)", required = true, schema = @Schema()) @PathVariable("idShortPath") String idShortPath,
 			@Parameter(in = ParameterIn.DEFAULT, description = "Requested submodel element", required = true, schema = @Schema()) @Valid @RequestBody SubmodelElement body) {
-		service.createSubmodelElement(idShortPath, body);
-		return new ResponseEntity<SubmodelElement>(body, HttpStatus.CREATED);
+		SubmodelElement createdSME = service.createSubmodelElement(idShortPath, body);
+		return new ResponseEntity<SubmodelElement>(createdSME, HttpStatus.CREATED);
 	}
 	
 	@Override

Original file line number	Diff line number	Diff line change
`@@ -197,21 +197,23 @@ public void setSubmodelElementValue(String submodelId, String smeIdShort, Submod`
`197`	`197`	`}`
`198`	`198`
`199`	`199`	`@Override`
`200`		`- public void createSubmodelElement(String submodelId, SubmodelElement smElement) {`
	`200`	`+ public SubmodelElement createSubmodelElement(String submodelId, SubmodelElement smElement) {`
`201`	`201`	`SubmodelService submodelService = getSubmodelServiceOrThrow(submodelId);`
`202`	`202`
`203`	`203`	`submodelService.createSubmodelElement(smElement);`
`204`	`204`
`205`	`205`	`updateSubmodel(submodelId, submodelService.getSubmodel());`
	`206`	`+ return smElement;`
`206`	`207`	`}`
`207`	`208`
`208`	`209`	`@Override`
`209`		`- public void createSubmodelElement(String submodelId, String idShortPath, SubmodelElement smElement) throws ElementDoesNotExistException {`
	`210`	`+ public SubmodelElement createSubmodelElement(String submodelId, String idShortPath, SubmodelElement smElement) throws ElementDoesNotExistException {`
`210`	`211`	`SubmodelService submodelService = getSubmodelServiceOrThrow(submodelId);`
`211`	`212`
`212`	`213`	`submodelService.createSubmodelElement(idShortPath, smElement);`
`213`	`214`
`214`	`215`	`updateSubmodel(submodelId, submodelService.getSubmodel());`
	`216`	`+ return smElement;`
`215`	`217`	`}`
`216`	`218`
`217`	`219`	`@Override`
Original file line number	Diff line number	Diff line change
`@@ -196,13 +196,13 @@ public void setSubmodelElementValue(String submodelId, String smeIdShort, Submod`
`196`	`196`	`}`
`197`	`197`
`198`	`198`	`@Override`
`199`		`- public void createSubmodelElement(String submodelId, SubmodelElement smElement) {`
`200`		`- getConnectedSubmodelService(submodelId).createSubmodelElement(smElement);`
	`199`	`+ public SubmodelElement createSubmodelElement(String submodelId, SubmodelElement smElement) {`
	`200`	`+ return getConnectedSubmodelService(submodelId).createSubmodelElement(smElement);`
`201`	`201`	`}`
`202`	`202`
`203`	`203`	`@Override`
`204`		`- public void createSubmodelElement(String submodelId, String idShortPath, SubmodelElement smElement) throws ElementDoesNotExistException {`
`205`		`- getConnectedSubmodelService(submodelId).createSubmodelElement(idShortPath, smElement);`
	`204`	`+ public SubmodelElement createSubmodelElement(String submodelId, String idShortPath, SubmodelElement smElement) throws ElementDoesNotExistException {`
	`205`	`+ return getConnectedSubmodelService(submodelId).createSubmodelElement(idShortPath, smElement);`
`206`	`206`	`}`
`207`	`207`
`208`	`208`	`@Override`
Original file line number	Diff line number	Diff line change
`@@ -86,14 +86,14 @@ public void setSubmodelElementValue(String idShortPath, SubmodelElementValue val`
`86`	`86`	`}`
`87`	`87`
`88`	`88`	`@Override`
`89`		`- public void createSubmodelElement(SubmodelElement submodelElement) {`
`90`		`- repoApi.createSubmodelElement(submodelId, submodelElement);`
	`89`	`+ public SubmodelElement createSubmodelElement(SubmodelElement submodelElement) {`
	`90`	`+ return repoApi.createSubmodelElement(submodelId, submodelElement);`
`91`	`91`	`}`
`92`	`92`
`93`	`93`	`@Override`
`94`		`- public void createSubmodelElement(String idShortPath, SubmodelElement submodelElement)`
	`94`	`+ public SubmodelElement createSubmodelElement(String idShortPath, SubmodelElement submodelElement)`
`95`	`95`	`throws ElementDoesNotExistException {`
`96`		`- repoApi.createSubmodelElement(submodelId, idShortPath, submodelElement);`
	`96`	`+ return repoApi.createSubmodelElement(submodelId, idShortPath, submodelElement);`
`97`	`97`
`98`	`98`	`}`
`99`	`99`
Original file line number	Diff line number	Diff line change
`@@ -155,21 +155,21 @@ public void setSubmodelElementValue(String submodelId, String smeIdShortPath, Su`
`155`	`155`	`}`
`156`	`156`
`157`	`157`	`@Override`
`158`		`- public void createSubmodelElement(String submodelId, SubmodelElement smElement) {`
	`158`	`+ public SubmodelElement createSubmodelElement(String submodelId, SubmodelElement smElement) {`
`159`	`159`	`boolean isAuthorized = permissionResolver.hasPermission(Action.UPDATE, new SubmodelTargetInformation(getIdAsList(submodelId), getIdAsList(ALL_ALLOWED_WILDCARD)));`
`160`	`160`
`161`	`161`	`throwExceptionIfInsufficientPermission(isAuthorized);`
`162`	`162`
`163`		`- decorated.createSubmodelElement(submodelId, smElement);`
	`163`	`+ return decorated.createSubmodelElement(submodelId, smElement);`
`164`	`164`	`}`
`165`	`165`
`166`	`166`	`@Override`
`167`		`- public void createSubmodelElement(String submodelId, String idShortPath, SubmodelElement smElement) throws ElementDoesNotExistException {`
	`167`	`+ public SubmodelElement createSubmodelElement(String submodelId, String idShortPath, SubmodelElement smElement) throws ElementDoesNotExistException {`
`168`	`168`	`boolean isAuthorized = permissionResolver.hasPermission(Action.UPDATE, new SubmodelTargetInformation(getIdAsList(submodelId), getIdAsList(idShortPath)));`
`169`	`169`
`170`	`170`	`throwExceptionIfInsufficientPermission(isAuthorized);`
`171`	`171`
`172`		`- decorated.createSubmodelElement(submodelId, idShortPath, smElement);`
	`172`	`+ return decorated.createSubmodelElement(submodelId, idShortPath, smElement);`
`173`	`173`	`}`
`174`	`174`
`175`	`175`	`@Override`
Original file line number	Diff line number	Diff line change
`@@ -99,17 +99,19 @@ public void setSubmodelElementValue(String submodelId, String idShortPath, Submo`
`99`	`99`	`}`
`100`	`100`
`101`	`101`	`@Override`
`102`		`- public void createSubmodelElement(String submodelId, SubmodelElement smElement) {`
	`102`	`+ public SubmodelElement createSubmodelElement(String submodelId, SubmodelElement smElement) {`
`103`	`103`	`decorated.createSubmodelElement(submodelId, smElement);`
`104`	`104`	`SubmodelElement submodelElement = decorated.getSubmodelElement(submodelId, smElement.getIdShort());`
`105`	`105`	`submodelElementCreated(submodelElement, getName(), submodelId, smElement.getIdShort());`
	`106`	`+ return submodelElement;`
`106`	`107`	`}`
`107`	`108`
`108`	`109`	`@Override`
`109`		`- public void createSubmodelElement(String submodelId, String idShortPath, SubmodelElement smElement) throws ElementDoesNotExistException {`
	`110`	`+ public SubmodelElement createSubmodelElement(String submodelId, String idShortPath, SubmodelElement smElement) throws ElementDoesNotExistException {`
`110`	`111`	`decorated.createSubmodelElement(submodelId, idShortPath, smElement);`
`111`	`112`	`SubmodelElement submodelElement = decorated.getSubmodelElement(submodelId, idShortPath);`
`112`	`113`	`submodelElementCreated(submodelElement, getName(), submodelId, idShortPath);`
	`114`	`+ return submodelElement;`
`113`	`115`	`}`
`114`	`116`
`115`	`117`	`@Override`
Original file line number	Diff line number	Diff line change
`@@ -117,13 +117,13 @@ public void setSubmodelElementValue(String submodelId, String smeIdShort, Submod`
`117`	`117`	`}`
`118`	`118`
`119`	`119`	`@Override`
`120`		`- public void createSubmodelElement(String submodelId, SubmodelElement smElement) {`
`121`		`- decorated.createSubmodelElement(submodelId, smElement);`
	`120`	`+ public SubmodelElement createSubmodelElement(String submodelId, SubmodelElement smElement) {`
	`121`	`+ return decorated.createSubmodelElement(submodelId, smElement);`
`122`	`122`	`}`
`123`	`123`
`124`	`124`	`@Override`
`125`		`- public void createSubmodelElement(String submodelId, String idShortPath, SubmodelElement smElement) throws ElementDoesNotExistException {`
`126`		`- decorated.createSubmodelElement(submodelId, idShortPath, smElement);`
	`125`	`+ public SubmodelElement createSubmodelElement(String submodelId, String idShortPath, SubmodelElement smElement) throws ElementDoesNotExistException {`
	`126`	`+ return decorated.createSubmodelElement(submodelId, idShortPath, smElement);`
`127`	`127`	`}`
`128`	`128`
`129`	`129`	`@Override`
Original file line number	Diff line number	Diff line change
`@@ -134,13 +134,13 @@ public void setSubmodelElementValue(String submodelId, String idShortPath, Submo`
`134`	`134`	`}`
`135`	`135`
`136`	`136`	`@Override`
`137`		`- public void createSubmodelElement(String submodelId, SubmodelElement submodelElement) {`
`138`		`- decorated.createSubmodelElement(submodelId, submodelElement);`
	`137`	`+ public SubmodelElement createSubmodelElement(String submodelId, SubmodelElement submodelElement) {`
	`138`	`+ return decorated.createSubmodelElement(submodelId, submodelElement);`
`139`	`139`	`}`
`140`	`140`
`141`	`141`	`@Override`
`142`		`- public void createSubmodelElement(String submodelId, String idShortPath, SubmodelElement submodelElement) throws ElementDoesNotExistException {`
`143`		`- decorated.createSubmodelElement(submodelId, idShortPath, submodelElement);`
	`142`	`+ public SubmodelElement createSubmodelElement(String submodelId, String idShortPath, SubmodelElement submodelElement) throws ElementDoesNotExistException {`
	`143`	`+ return decorated.createSubmodelElement(submodelId, idShortPath, submodelElement);`
`144`	`144`	`}`
`145`	`145`
`146`	`146`	`@Override`
Original file line number	Diff line number	Diff line change
`@@ -123,12 +123,13 @@ public void setSubmodelElementValue(String idShort, SubmodelElementValue value)`
`123`	`123`	`}`
`124`	`124`
`125`	`125`	`@Override`
`126`		`- public void createSubmodelElement(SubmodelElement submodelElement) throws CollidingIdentifierException {`
	`126`	`+ public SubmodelElement createSubmodelElement(SubmodelElement submodelElement) throws CollidingIdentifierException {`
`127`	`127`	`throwIfSubmodelElementExists(submodelElement.getIdShort());`
`128`	`128`
`129`	`129`	`List<SubmodelElement> smElements = submodel.getSubmodelElements();`
`130`	`130`	`smElements.add(submodelElement);`
`131`	`131`	`submodel.setSubmodelElements(smElements);`
	`132`	`+ return submodelElement;`
`132`	`133`	`}`
`133`	`134`
`134`	`135`	`private void throwIfSubmodelElementExists(String submodelElementId) {`
`@@ -141,7 +142,7 @@ private void throwIfSubmodelElementExists(String submodelElementId) {`
`141`	`142`	`}`
`142`	`143`
`143`	`144`	`@Override`
`144`		`- public void createSubmodelElement(String idShortPath, SubmodelElement submodelElement) throws ElementDoesNotExistException, CollidingIdentifierException {`
	`145`	`+ public SubmodelElement createSubmodelElement(String idShortPath, SubmodelElement submodelElement) throws ElementDoesNotExistException, CollidingIdentifierException {`
`145`	`146`	`throwIfSubmodelElementExists(getFullIdShortPath(idShortPath, submodelElement.getIdShort()));`
`146`	`147`
`147`	`148`	`SubmodelElement parentSme = parser.getSubmodelElementFromIdShortPath(idShortPath);`
`@@ -150,15 +151,14 @@ public void createSubmodelElement(String idShortPath, SubmodelElement submodelEl`
`150`	`151`	`List<SubmodelElement> submodelElements = list.getValue();`
`151`	`152`	`submodelElements.add(submodelElement);`
`152`	`153`	`list.setValue(submodelElements);`
`153`		`- return;`
`154`	`154`	`}`
`155`	`155`	`if (parentSme instanceof SubmodelElementCollection) {`
`156`	`156`	`SubmodelElementCollection collection = (SubmodelElementCollection) parentSme;`
`157`	`157`	`List<SubmodelElement> submodelElements = collection.getValue();`
`158`	`158`	`submodelElements.add(submodelElement);`
`159`	`159`	`collection.setValue(submodelElements);`
`160`		`- return;`
`161`	`160`	`}`
	`161`	`+ return submodelElement;`
`162`	`162`	`}`
`163`	`163`
`164`	`164`	`@Override`