Commit 8800bff
authored
server/README.md: Clarify Docker build context (#398)
Previously, #386 proposed narrowing the scope of the build context for
'server/Dockerfile' to '/server'. As a consequence, `/sdk`, which is
required to build the server, would no longer be accessible. Locally,
this would necessitate explicitly referencing `/sdk` as a second
build context. When using the GitHub URL of this repository as build
context instead of a local repository, this would additionally lead to
inefficient data handling. Since Docker Compose does not yet support
sparse checkouts, specifying subdirectories like `/server` as build
context still results in the full repository being cloned. Consequently,
although `/sdk` would be downloaded, it would be excluded from the
narrowed build context and thus remain unavailable. Any attempt to
include `/sdk` separately afterwards would result in the same data being
downloaded again. As this is an inefficient solution, #386 is rejected.
This documents the decision of keeping the repository root as the build
context of `server/Dockerfile`. A corresponding note was added in
`server/README.md`.
Additionally, a mention of faulty line endings being a common error when
building the Docker container has been added in `server/README.md`.
Fixes #3861 parent 5043c20 commit 8800bff
1 file changed
+4
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
| 21 | + | |
| 22 | + | |
21 | 23 | | |
22 | 24 | | |
23 | 25 | | |
| |||
77 | 79 | | |
78 | 80 | | |
79 | 81 | | |
80 | | - | |
81 | 82 | | |
82 | 83 | | |
83 | 84 | | |
84 | 85 | | |
85 | 86 | | |
| 87 | + | |
| 88 | + | |
86 | 89 | | |
87 | 90 | | |
88 | 91 | | |
| |||
0 commit comments