Commit cab5bf2
committed
server/README.md: Clarify Docker build context
Previously, narrowing the Docker build context of `server/Dockerfile` to
`/server` was discussed to reduce scope. However, this would exclude
`/sdk`, which is needed for building the server. Locally, it would then
be necessary to explicitly reference `/sdk` as a second build context.
Externally, when using the link to this GitHub repository as build
context, it would lead to unnecessary cloning. As Docker does not yet
support sparse checkouts, referencing subdirectories such as `/server`
results in the entire repository being cloned regardless. Therefore, the
required `/sdk` would be cloned but made unavailable by narrowing the
build context. Any second clone of `/sdk` would therefore result in data
that had already been downloaded being downloaded again. To include
`/sdk` efficiently, the build context must remain the repository root.
This documents the decision of keeping the repository root as the build
context of `server/Dockerfile`. A corresponding note was added in
`server/README.md`.
Additionally, a mention of faulty line endings being a common error when
building the Docker container has been added in `server/README.md`.
Fixes #3861 parent e043960 commit cab5bf2
1 file changed
+4
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
| 21 | + | |
| 22 | + | |
21 | 23 | | |
22 | 24 | | |
23 | 25 | | |
| |||
77 | 79 | | |
78 | 80 | | |
79 | 81 | | |
80 | | - | |
81 | 82 | | |
82 | 83 | | |
83 | 84 | | |
84 | 85 | | |
85 | 86 | | |
| 87 | + | |
| 88 | + | |
86 | 89 | | |
87 | 90 | | |
88 | 91 | | |
| |||
0 commit comments