Checkstyle: naming: LocalVariableName

Author: Korbik

src/main/java/org/biscuitsec/biscuit/datalog/expressions/Op.java

@@ -535,11 +535,11 @@ public void evaluate(Deque<Term> stack, Map<Long, Term> variables, TemporarySymb
         case Intersection:
           if (right instanceof Term.Set && left instanceof Term.Set) {
             HashSet<Term> intersec = new HashSet<Term>();
-            HashSet<Term> sRight = ((Term.Set) right).value();
-            HashSet<Term> sLeft = ((Term.Set) left).value();
-            for (Term lId : sRight) {
-              if (sLeft.contains(lId)) {
-                intersec.add(lId);
+            HashSet<Term> setRight = ((Term.Set) right).value();
+            HashSet<Term> setLeft = ((Term.Set) left).value();
+            for (Term locId : setRight) {
+              if (setLeft.contains(locId)) {
+                intersec.add(locId);
               }
             }
             stack.push(new Term.Set(intersec));
@@ -548,10 +548,10 @@ public void evaluate(Deque<Term> stack, Map<Long, Term> variables, TemporarySymb
         case Union:
           if (right instanceof Term.Set && left instanceof Term.Set) {
             HashSet<Term> union = new HashSet<Term>();
-            HashSet<Term> sRight = ((Term.Set) right).value();
-            HashSet<Term> sLeft = ((Term.Set) left).value();
-            union.addAll(sRight);
-            union.addAll(sLeft);
+            HashSet<Term> setRight = ((Term.Set) right).value();
+            HashSet<Term> setLeft = ((Term.Set) left).value();
+            union.addAll(setRight);
+            union.addAll(setLeft);
             stack.push(new Term.Set(union));
           }
           break;

src/main/java/org/biscuitsec/biscuit/token/Authorizer.java

@@ -139,11 +139,11 @@ public void updateOnToken() throws Error.FailedLogic {
         world.addFact(new Origin(0), convertedFact);
       }
       for (org.biscuitsec.biscuit.datalog.Rule rule : token.authority.rules()) {
-        org.biscuitsec.biscuit.token.builder.Rule lRule =
+        org.biscuitsec.biscuit.token.builder.Rule locRule =
             org.biscuitsec.biscuit.token.builder.Rule.convertFrom(rule, token.symbols);
-        org.biscuitsec.biscuit.datalog.Rule convertedRule = lRule.convert(this.symbols);
+        org.biscuitsec.biscuit.datalog.Rule convertedRule = locRule.convert(this.symbols);
 
-        Either<String, org.biscuitsec.biscuit.token.builder.Rule> res = lRule.validateVariables();
+        Either<String, org.biscuitsec.biscuit.token.builder.Rule> res = locRule.validateVariables();
         if (res.isLeft()) {
           throw new Error.FailedLogic(
               new LogicError.InvalidBlockRule(0, token.symbols.formatRule(convertedRule)));
@@ -174,11 +174,11 @@ public void updateOnToken() throws Error.FailedLogic {
         }
 
         for (org.biscuitsec.biscuit.datalog.Rule rule : block.rules()) {
-          org.biscuitsec.biscuit.token.builder.Rule sRule =
+          org.biscuitsec.biscuit.token.builder.Rule symRole =
               org.biscuitsec.biscuit.token.builder.Rule.convertFrom(rule, blockSymbols);
-          org.biscuitsec.biscuit.datalog.Rule convertedRule = sRule.convert(this.symbols);
+          org.biscuitsec.biscuit.datalog.Rule convertedRule = symRole.convert(this.symbols);
 
-          Either<String, org.biscuitsec.biscuit.token.builder.Rule> res = sRule.validateVariables();
+          Either<String, org.biscuitsec.biscuit.token.builder.Rule> res = symRole.validateVariables();
           if (res.isLeft()) {
             throw new Error.FailedLogic(
                 new LogicError.InvalidBlockRule(0, this.symbols.formatRule(convertedRule)));

src/main/java/org/biscuitsec/biscuit/token/builder/Fact.java

@@ -58,10 +58,10 @@ public Fact set(String name, Term term) throws Error.Language {
     if (this.variables.isEmpty()) {
       throw new Error.Language(new FailedCheck.LanguageError.UnknownVariable(name));
     }
-    Map<String, Option<Term>> lVariables = this.variables.get();
-    Option<Term> r = lVariables.get(name);
+    Map<String, Option<Term>> localVariables = this.variables.get();
+    Option<Term> r = localVariables.get(name);
     if (r != null) {
-      lVariables.put(name, Option.some(term));
+      localVariables.put(name, Option.some(term));
     } else {
       throw new Error.Language(new FailedCheck.LanguageError.UnknownVariable(name));
     }