Skip to content

Commit fddf7a3

Browse files
committed
BlockSignatureBuffer: rename from BlockBuffer
1 parent 609dc50 commit fddf7a3

File tree

5 files changed

+15
-15
lines changed

5 files changed

+15
-15
lines changed

src/main/java/org/biscuitsec/biscuit/crypto/BlockBuffer.java renamed to src/main/java/org/biscuitsec/biscuit/crypto/BlockSignatureBuffer.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
import java.nio.ByteOrder;
77
import java.util.Optional;
88

9-
public class BlockBuffer {
9+
public class BlockSignatureBuffer {
1010
public static byte[] getBufferSignature(PublicKey nextPubKey, byte[] data) {
1111
return getBufferSignature(nextPubKey, data, Optional.empty());
1212
}

src/main/java/org/biscuitsec/biscuit/crypto/Token.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ class Token {
1919

2020
public Token(final Signer rootSigner, byte[] message, KeyPair next) throws NoSuchAlgorithmException, InvalidKeyException, SignatureException {
2121

22-
byte[] payload = BlockBuffer.getBufferSignature(next.public_key(), message);
22+
byte[] payload = BlockSignatureBuffer.getBufferSignature(next.public_key(), message);
2323

2424
byte[] signature = rootSigner.sign(payload);
2525

@@ -41,7 +41,7 @@ public Token(final ArrayList<byte[]> blocks, final ArrayList<PublicKey> keys, fi
4141
}
4242

4343
public Token append(KeyPair keyPair, byte[] message) throws NoSuchAlgorithmException, SignatureException, InvalidKeyException {
44-
byte[] payload = BlockBuffer.getBufferSignature(keyPair.public_key(), message);
44+
byte[] payload = BlockSignatureBuffer.getBufferSignature(keyPair.public_key(), message);
4545
byte[] signature = this.next.sign(payload);
4646

4747
Token token = new Token(this.blocks, this.keys, this.signatures, keyPair);
@@ -60,7 +60,7 @@ public Either<Error, Void> verify(PublicKey root) throws NoSuchAlgorithmExceptio
6060
PublicKey next_key = this.keys.get(i);
6161
byte[] signature = this.signatures.get(i);
6262

63-
byte[] payload = BlockBuffer.getBufferSignature(next_key, block);
63+
byte[] payload = BlockSignatureBuffer.getBufferSignature(next_key, block);
6464
if (KeyPair.verify(current_key, payload, signature)) {
6565
current_key = next_key;
6666
} else {

src/main/java/org/biscuitsec/biscuit/token/ThirdPartyBlockRequest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
import com.google.protobuf.InvalidProtocolBufferException;
55
import io.vavr.control.Either;
66
import io.vavr.control.Option;
7-
import org.biscuitsec.biscuit.crypto.BlockBuffer;
7+
import org.biscuitsec.biscuit.crypto.BlockSignatureBuffer;
88
import org.biscuitsec.biscuit.crypto.PublicKey;
99
import org.biscuitsec.biscuit.crypto.Signer;
1010
import org.biscuitsec.biscuit.datalog.SymbolTable;
@@ -33,7 +33,7 @@ public Either<Error.FormatError, ThirdPartyBlockContents> createBlock(final Sign
3333
}
3434

3535
byte[] serializedBlock = res.get();
36-
byte[] payload = BlockBuffer.getBufferSignature(this.previousKey, serializedBlock);
36+
byte[] payload = BlockSignatureBuffer.getBufferSignature(this.previousKey, serializedBlock);
3737
byte[] signature = externalSigner.sign(payload);
3838

3939
PublicKey publicKey = externalSigner.public_key();

src/main/java/org/biscuitsec/biscuit/token/UnverifiedBiscuit.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
package org.biscuitsec.biscuit.token;
22

33
import biscuit.format.schema.Schema.PublicKey.Algorithm;
4-
import org.biscuitsec.biscuit.crypto.BlockBuffer;
4+
import org.biscuitsec.biscuit.crypto.BlockSignatureBuffer;
55
import org.biscuitsec.biscuit.crypto.KeyDelegate;
66
import org.biscuitsec.biscuit.crypto.KeyPair;
77
import org.biscuitsec.biscuit.crypto.PublicKey;
@@ -239,7 +239,7 @@ public UnverifiedBiscuit appendThirdPartyBlock(PublicKey externalKey, ThirdParty
239239
previousKey = this.serializedBiscuit.blocks.get(this.serializedBiscuit.blocks.size() - 1).key;
240240
}
241241
KeyPair nextKeyPair = KeyPair.generate(previousKey.algorithm);
242-
byte[] payload = BlockBuffer.getBufferSignature(previousKey, blockResponse.payload);
242+
byte[] payload = BlockSignatureBuffer.getBufferSignature(previousKey, blockResponse.payload);
243243
if (!KeyPair.verify(externalKey, payload, blockResponse.signature)) {
244244
throw new Error.FormatError.Signature.InvalidSignature("signature error: Verification equation was not satisfied");
245245
}

src/main/java/org/biscuitsec/biscuit/token/format/SerializedBiscuit.java

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
import biscuit.format.schema.Schema;
44
import io.vavr.Tuple2;
5-
import org.biscuitsec.biscuit.crypto.BlockBuffer;
5+
import org.biscuitsec.biscuit.crypto.BlockSignatureBuffer;
66
import org.biscuitsec.biscuit.crypto.KeyDelegate;
77
import org.biscuitsec.biscuit.crypto.KeyPair;
88
import org.biscuitsec.biscuit.crypto.PublicKey;
@@ -239,7 +239,7 @@ static public Either<Error.FormatError, SerializedBiscuit> make(final org.biscui
239239
b.writeTo(stream);
240240
byte[] block = stream.toByteArray();
241241
org.biscuitsec.biscuit.crypto.PublicKey next_key = next.public_key();
242-
byte[] payload = BlockBuffer.getBufferSignature(next_key, block);
242+
byte[] payload = BlockSignatureBuffer.getBufferSignature(next_key, block);
243243
byte[] signature = rootSigner.sign(payload);
244244
SignedBlock signedBlock = new SignedBlock(block, next_key, signature, Option.none());
245245
Proof proof = new Proof(next);
@@ -265,7 +265,7 @@ public Either<Error.FormatError, SerializedBiscuit> append(final org.biscuitsec.
265265
KeyPair secretKey = this.proof.secretKey.get();
266266
org.biscuitsec.biscuit.crypto.PublicKey next_key = next.public_key();
267267

268-
byte[] payload = BlockBuffer.getBufferSignature(next_key, block, externalSignature.toJavaOptional());
268+
byte[] payload = BlockSignatureBuffer.getBufferSignature(next_key, block, externalSignature.toJavaOptional());
269269
byte[] signature = this.proof.secretKey.get().sign(payload);
270270

271271
SignedBlock signedBlock = new SignedBlock(block, next_key, signature, externalSignature);
@@ -335,7 +335,7 @@ public Either<Error, Void> verify(org.biscuitsec.biscuit.crypto.PublicKey root)
335335
org.biscuitsec.biscuit.crypto.PublicKey next_key = b.key;
336336
byte[] signature = b.signature;
337337

338-
byte[] payload = BlockBuffer.getBufferSealedSignature(next_key, block, signature);
338+
byte[] payload = BlockSignatureBuffer.getBufferSealedSignature(next_key, block, signature);
339339

340340
if (KeyPair.verify(current_key, payload, finalSignature)) {
341341
return Right(null);
@@ -370,13 +370,13 @@ static Either<Error, org.biscuitsec.biscuit.crypto.PublicKey> verifyBlockSignatu
370370
}
371371
sgr.update(algo_buf);
372372
sgr.update(next_key.toBytes());
373-
byte[] payload = BlockBuffer.getBufferSignature(next_key, block, signedBlock.externalSignature.toJavaOptional());
373+
byte[] payload = BlockSignatureBuffer.getBufferSignature(next_key, block, signedBlock.externalSignature.toJavaOptional());
374374
if (!KeyPair.verify(publicKey, payload, signature)) {
375375
return Left(new Error.FormatError.Signature.InvalidSignature("signature error: Verification equation was not satisfied"));
376376
}
377377

378378
if (signedBlock.externalSignature.isDefined()) {
379-
byte[] externalPayload = BlockBuffer.getBufferSignature(publicKey, block);
379+
byte[] externalPayload = BlockSignatureBuffer.getBufferSignature(publicKey, block);
380380
ExternalSignature externalSignature = signedBlock.externalSignature.get();
381381

382382
if (!KeyPair.verify(externalSignature.key, externalPayload, externalSignature.signature)) {
@@ -448,7 +448,7 @@ public Either<Error, Void> seal() throws InvalidKeyException, NoSuchAlgorithmExc
448448
}
449449

450450
KeyPair secretKey = this.proof.secretKey.get();
451-
byte[] payload = BlockBuffer.getBufferSealedSignature(block.key, block.block, block.signature);
451+
byte[] payload = BlockSignatureBuffer.getBufferSealedSignature(block.key, block.block, block.signature);
452452
byte[] signature = secretKey.sign(payload);
453453

454454
this.proof.secretKey = Option.none();

0 commit comments

Comments
 (0)