Suppressing unneeded error message when hovering (#366)

* suppressed the error message of var-create when user is hovering over a non variable

* suppressing -var-create error

* editing evaluate request test

Author: omarArm

src/gdb/GDBDebugSessionBase.ts

@@ -1272,11 +1272,21 @@ export abstract class GDBDebugSessionBase extends LoggingDebugSession {
 
             this.sendResponse(response);
         } catch (err) {
-            this.sendErrorResponse(
-                response,
-                1,
-                err instanceof Error ? err.message : String(err)
-            );
+            if (
+                err instanceof Error &&
+                err.message === '-var-create: unable to create variable object'
+            ) {
+                if (args.context === 'hover') {
+                    response.success = false;
+                }
+                this.sendResponse(response);
+            } else {
+                this.sendErrorResponse(
+                    response,
+                    1,
+                    err instanceof Error ? err.message : String(err)
+                );
+            }
         }
     }
 

src/integration-tests/evaluate.spec.ts

@@ -68,16 +68,14 @@ describe('evaluate request', function () {
         );
     });
 
-    it('should reject evaluation of invalid expression', async function () {
-        const err = await expectRejection(
-            dc.evaluateRequest({
-                context: 'repl',
-                expression: '2 +',
-                frameId: scope.frame.id,
-            })
-        );
+    it('should send an error when evaluating an invalid expression', async function () {
+        const err = await dc.evaluateRequest({
+            context: 'repl',
+            expression: '2 +',
+            frameId: scope.frame.id,
+        });
 
-        expect(err.message).eq('-var-create: unable to create variable object');
+        expect(err.body.result).eq('Error: could not evaluate expression');
     });
     it('should be able to update the value of a variable named monitor and that variable has local scope', async function () {
         const res1 = await dc.evaluateRequest({