Incorrect sequence of launch/attach and configurationDone responses

[cwalther]

Things I am planning to work on as part of my exploration of how to debug Indel industrial control systems with Visual Studio Code:

Currently, the debug adapter protocol is not implemented correctly in that the launch/attach response is not delayed until after the configurationDone response as specified (clearly) in microsoft/vscode#4902 (comment) and (a little less clearly, in my opinion) in the protocol specs.

I have not seen any adverse effects of this while working in Visual Studio Code, but it would probably be good to correctly implement the protocol anyway.

[jonahgraham]

@cwalther I agree with your assessment - this was briefly brought up in #95 (comment) when the adapter was first being written but the maintainers at the time were ok with the incorrect implementation.

[cwalther]

I have started work on this, and while the implementation is simple enough, it breaks a bunch of tests, apparently because they either wait for the launch response before sending the configurationDone request, or don’t send a configurationDone request at all. Sorting through all those will take some time.

As far as I understand the protocol specification, the configurationDone request is mandatory when the adapter announces support for it, there is no way for the client to decline support for it (support is only announced in one direction in the initialize request handshake). Therefore those tests are wrong and must be fixed. Or am I mistaken?