Skip to content

Commit 8f15c4f

Browse files
Give gdbserver time to gracefully disconnect before terminating it (#175)
* Give gdbserver time to gracefully disconnect before terminating it * changed timeout, renamed var * changed comment / description
1 parent a05305c commit 8f15c4f

File tree

3 files changed

+10
-0
lines changed

3 files changed

+10
-0
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
# Change Log
22

3+
# Unreleased
4+
5+
- Fixes [#398](https://github.com/eclipse-cdt-cloud/cdt-gdb-adapter/issues/398): Give gdbserver time to gracefully disconnect before terminating it
6+
37
# 2.1.0
48

59
- Adds [PR #168](https://github.com/eclipse-cdt-cloud/cdt-gdb-vscode/pull/168): Supported languages for `gdb` and `gdbtarget` debug adapter types to show `Open Disassembly View` context menu entry in source code editors.

README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -86,6 +86,7 @@ Additional settings to configure the remote GDB target. This object can be used
8686
| `serverParameters` | x | | `string[]` | Command line arguments passed to server.<br>Default: `--once :0 ${args.program}` |
8787
| `serverPortRegExp` | x | | `string` | Regular expression to extract `port` from by examining stdout/stderr of the GDB server. Once the server is launched, `port` will be set to this if unspecified. Defaults to matching a string like `Listening on port 41551` which is what `gdbserver` provides. Ignored if `port` or `parameters` is set. |
8888
| `portDetectionTimeout` | x | | `number` | Timeout for port detection based on `serverPortRegExp`. Default value is `10000` (ms). |
89+
| `serverDisconnectTimeout` | x | | `number` |Timeout for GDB server disconnect request. Default value is 1000 (ms). |
8990
| `serverStartupDelay` | x | | `number` | Delay, in milliseconds, after startup but before continuing launch. If `serverPortRegExp` is provided, it is the delay after that regexp is seen. |
9091
| `automaticallyKillServer` | x | | `boolean` | Automatically terminate the launched server when client issues a disconnect.<br>Default: `true` |
9192
| `uart` | x | x | `object` | Settings related to displaying UART output in the debug console. |

package.json

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -429,6 +429,11 @@
429429
"type": "boolean",
430430
"description": "Automatically kill the launched server when client issues a disconnect (default: true)"
431431
},
432+
"serverDisconnectTimeout": {
433+
"type": "number",
434+
"description": "Timeout for GDB server disconnect request. Default value is 1000 (ms).",
435+
"default": 1000
436+
},
432437
"uart": {
433438
"type": "object",
434439
"description": "Settings related to displaying UART output in the debug console",

0 commit comments

Comments
 (0)