Skip to content

Commit f6232c4

Browse files
Use node.js 20
Node 18 is EoL soon, so let's switch to using node 20 by default. Signed-off-by: Marc Dumais <[email protected]>
1 parent 70460a7 commit f6232c4

File tree

6 files changed

+66
-7
lines changed

6 files changed

+66
-7
lines changed

.github/workflows/docker-example.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ jobs:
2121
- name: "tave"
2222
resources-folder: "theia-app-vscode-ext"
2323
os: [ubuntu-latest]
24-
node-version: [18]
24+
node-version: [20]
2525

2626
steps:
2727
- uses: actions/checkout@v4

docker/Dockerfile-tate

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
FROM node:18.20.4-bookworm-slim AS build
1+
FROM node:20.18.2-bookworm-slim AS build
22
ARG RESOURCES
33

44
RUN apt-get update && apt-get install -y \
@@ -25,7 +25,7 @@ RUN yarn && \
2525
yarn --production && \
2626
yarn cache clean
2727

28-
FROM node:18.19.1-bookworm-slim
28+
FROM node:20.18.2-bookworm-slim
2929
ARG RESOURCES
3030

3131
COPY --from=build /app/tv /app/tv

docker/Dockerfile-tave

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
FROM node:18.20.4-bookworm-slim AS build
1+
FROM node:20.18.2-bookworm-slim AS build
22
ARG RESOURCES
33

44
RUN apt-get update && apt-get install -y \
@@ -27,7 +27,7 @@ RUN yarn && \
2727
yarn --production && \
2828
yarn cache clean
2929

30-
FROM node:18.19.1-bookworm-slim
30+
FROM node:20.18.2-bookworm-slim
3131
ARG RESOURCES
3232

3333
COPY --from=build /app/tv /app/tv

docker/diff.txt

Lines changed: 59 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,59 @@
1+
diff --git a/.github/workflows/docker-example.yml b/.github/workflows/docker-example.yml
2+
index 94fa5b6..c519e15 100644
3+
--- a/.github/workflows/docker-example.yml
4+
+++ b/.github/workflows/docker-example.yml
5+
@@ -21,7 +21,7 @@ jobs:
6+
- name: "tave"
7+
resources-folder: "theia-app-vscode-ext"
8+
os: [ubuntu-latest]
9+
- node-version: [18]
10+
+ node-version: [20]
11+
12+
steps:
13+
- uses: actions/checkout@v4
14+
diff --git a/docker/Dockerfile-tate b/docker/Dockerfile-tate
15+
index 01996da..b31661e 100644
16+
--- a/docker/Dockerfile-tate
17+
+++ b/docker/Dockerfile-tate
18+
@@ -1,4 +1,4 @@
19+
-FROM node:18.20.4-bookworm-slim AS build
20+
+FROM node:20.18.2-bookworm-slim AS build
21+
ARG RESOURCES
22+
23+
RUN apt-get update && apt-get install -y \
24+
diff --git a/docker/Dockerfile-tave b/docker/Dockerfile-tave
25+
index c362b2b..88567e2 100644
26+
--- a/docker/Dockerfile-tave
27+
+++ b/docker/Dockerfile-tave
28+
@@ -1,4 +1,4 @@
29+
-FROM node:18.20.4-bookworm-slim AS build
30+
+FROM node:20.18.2-bookworm-slim AS build
31+
ARG RESOURCES
32+
33+
RUN apt-get update && apt-get install -y \
34+
diff --git a/docker/theia-app-theia-ext/package.json b/docker/theia-app-theia-ext/package.json
35+
index b0aba80..ab7a1a5 100644
36+
--- a/docker/theia-app-theia-ext/package.json
37+
+++ b/docker/theia-app-theia-ext/package.json
38+
@@ -37,7 +37,7 @@
39+
},
40+
"engines": {
41+
"yarn": ">=1.7.0 <2",
42+
- "node": ">=18 <21"
43+
+ "node": ">=18 <23"
44+
},
45+
"resolutions": {
46+
47+
diff --git a/docker/theia-app-vscode-ext/package.json b/docker/theia-app-vscode-ext/package.json
48+
index 48aeaf4..26b2de2 100644
49+
--- a/docker/theia-app-vscode-ext/package.json
50+
+++ b/docker/theia-app-vscode-ext/package.json
51+
@@ -39,7 +39,7 @@
52+
},
53+
"engines": {
54+
"yarn": ">=1.7.0 <2",
55+
- "node": ">=18 <21"
56+
+ "node": ">=18 <23"
57+
},
58+
"theiaPluginsDir": "plugins",
59+
"theiaPlugins": {

docker/theia-app-theia-ext/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@
3737
},
3838
"engines": {
3939
"yarn": ">=1.7.0 <2",
40-
"node": ">=18 <21"
40+
"node": ">=18 <23"
4141
},
4242
"resolutions": {
4343

docker/theia-app-vscode-ext/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@
3939
},
4040
"engines": {
4141
"yarn": ">=1.7.0 <2",
42-
"node": ">=18 <21"
42+
"node": ">=18 <23"
4343
},
4444
"theiaPluginsDir": "plugins",
4545
"theiaPlugins": {

0 commit comments

Comments
 (0)