Skip to content

Commit 28dd898

Browse files
[traceviewer-base] explicitly request recent prettier dependency
When the traceviewer-libs git subtree was initially added, running prettier (yarn format:check) would fail locally. This was since determine to be because this repo here was already pulling a more recent version of "prettier" than the theia extension repo: v3.x vs v2.x. The local version of the subtree already has the libraries' code adapted to pass the check with prettier@3. That version was explicitly added as a devDependency to the traceviewer- react-components library, but for completeness, we now add it to traceviwewer-base as well, to be sure the format check will be identical in both repositories, no matter the version of prettier that may be pulled in the root package.json or other components, in either / both repositories. Signed-off-by: Marc Dumais <[email protected]>
1 parent 7b8fb37 commit 28dd898

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

base/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@
2525
"eslint-plugin-import": "^2.21.2",
2626
"eslint-plugin-no-null": "^1.0.2",
2727
"eslint-plugin-react": "^7.20.0",
28+
"prettier": "^3.6.2",
2829
"rimraf": "^5.0.0",
2930
"typescript": "4.9.5"
3031
},

0 commit comments

Comments
 (0)