Skip to content

Commit 03173f7

Browse files
Siwei Zhangbhufmann
authored andcommitted
Add parameter "properties" in class Trace
Add the parameter "properties" introduced by commit 499408e3979cab403a5d588fe9b413d1e9fbdbfb in the server. Signed-off-by: Siwei Zhang <[email protected]>
1 parent b7d8db5 commit 03173f7

File tree

3 files changed

+43
-2
lines changed

3 files changed

+43
-2
lines changed

test_tsp.py

Lines changed: 33 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -208,6 +208,39 @@ def test_open_experiment(self, kernel, other):
208208
self._delete_experiments()
209209
self._delete_traces()
210210

211+
def test_opened_trace_info(self, kernel, other):
212+
"""Expect the info of the trace correctly set."""
213+
traces = []
214+
response = self.tsp_client.open_trace(os.path.basename(kernel), kernel)
215+
traces.append(response.model.UUID)
216+
217+
# The trace info in read after it is opened in an
218+
# experiment, so open the experiment here.
219+
response = self.tsp_client.open_experiment(
220+
os.path.basename(kernel), traces)
221+
assert response.status_code == 200
222+
223+
trace = response.model.traces.traces[0]
224+
assert trace.start == 1332170682440133097
225+
assert trace.end == 1332170682702071857
226+
assert trace.path.endswith('/tracecompass-test-traces/ctf/src/main/resources/kernel')
227+
assert isinstance(trace.properties, dict)
228+
assert len(trace.properties) == 11
229+
assert trace.properties["clock_offset"] == '1332166405241713987'
230+
assert trace.properties["clock_scale"] == '1.0'
231+
assert trace.properties["domain"] == '"kernel"'
232+
assert trace.properties["host ID"] == '"84db105b-b3f4-4821-b662-efc51455106a"'
233+
assert trace.properties['tracer_name'] == '"lttng-modules"'
234+
assert trace.properties['tracer_major'] == '2'
235+
assert trace.properties['tracer_minor'] == '0'
236+
assert trace.properties['kernel_release'] == '"3.0.0-16-generic-pae"'
237+
assert trace.properties['sysname'] == '"Linux"'
238+
assert trace.properties['tracer_patchlevel'] == '0'
239+
assert trace.properties['kernel_version'] == '"#29-Ubuntu SMP Tue Feb 14 13:56:31 UTC 2012"'
240+
241+
self._delete_experiments()
242+
self._delete_traces()
243+
211244
def test_open_experiment_unopened_trace(self, kernel):
212245
"""Expect 204 after opening experiment with unopened trace."""
213246
traces = []

tsp/trace.py

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@
3333
PATH_KEY = "path"
3434
NB_EVENT_KEY = "nbEvents"
3535
PATH_TIME_KEY = "path"
36+
PROPERTIES_KEY = "properties"
3637
INDEXING_STATUS_KEY = "indexingStatus"
3738

3839

@@ -91,6 +92,13 @@ def __init__(self, params):
9192
else: # pragma: no cover
9293
self.number_of_events = 0
9394

95+
# Properties of the trace
96+
if PROPERTIES_KEY in params:
97+
self.properties = params.get(PROPERTIES_KEY)
98+
del params[PROPERTIES_KEY]
99+
else: # pragma: no cover
100+
self.properties = {}
101+
94102
# Indicate if the indexing of the trace is completed or still running.
95103
# If it still running, the end time and number of events are not final
96104
if INDEXING_STATUS_KEY in params:

tsp_cli_client

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,9 +66,9 @@ def __print_experiment(elem):
6666

6767

6868
def __print_trace(elem):
69-
print(' {0}: {1} ({2}) start={3} end={4} nbEvents={5} indexing={6}'.format(
69+
print(' {0}: {1} ({2}) start={3} end={4} nbEvents={5} properties={6} indexing={7}'.format(
7070
elem.name, elem.path, __print_uuid(elem), elem.start, elem.end,
71-
elem.number_of_events, elem.indexing_status))
71+
elem.number_of_events, elem.properties, elem.indexing_status))
7272

7373

7474
def __print_output(output):

0 commit comments

Comments
 (0)