Conditional 'Show In Memory Inspector' for Variable

Add new conditional for context menu showing Memory Inspector for a
variable because some DAPs may not support it.

Signed-off-by: Thor Thayer <[email protected]>

Author: WyoTwT

package.json

@@ -142,7 +142,7 @@
       "debug/variables/context": [
         {
           "command": "memory-inspector.show-variable",
-          "when": "canViewMemory && memory-inspector.canRead"
+          "when": "canViewMemory && memory-inspector.canReadVariable"
         },
         {
           "command": "memory-inspector.store-file",
@@ -152,7 +152,7 @@
       "view/item/context": [
         {
           "command": "memory-inspector.show-variable",
-          "when": "canViewMemory && memory-inspector.canRead"
+          "when": "canViewMemory && memory-inspector.canReadVariable"
         }
       ],
       "explorer/context": [

src/common/messaging.ts

@@ -47,6 +47,7 @@ export interface SessionContext {
     sessionId?: string;
     canRead: boolean;
     canWrite: boolean;
+    canReadVariable: boolean;
 }
 
 // Notifications

src/plugin/adapter-registry/adapter-capabilities.ts

@@ -36,6 +36,7 @@ export interface AdapterCapabilities {
     writeMemory?(session: vscode.DebugSession, params: WriteMemoryArguments, context?: Context): Promise<WriteMemoryResult>;
     getContexts?(session: vscode.DebugSession): Promise<Context[]>;
     getCurrentContext?(session: vscode.DebugSession): Promise<Context | undefined>;
+    supportShowVariables?(session: vscode.DebugSession): boolean;
 }
 
 export type WithChildren<Original> = Original & { children?: Array<WithChildren<DebugProtocol.Variable>> };
@@ -143,6 +144,8 @@ export class AdapterVariableTracker implements vscode.DebugAdapterTracker {
 
     getContexts?(session: vscode.DebugSession): Promise<Context[]>;
     getCurrentContext?(session: vscode.DebugSession): Promise<Context | undefined>;
+
+    supportShowVariables?(session: vscode.DebugSession): boolean;
 }
 
 export class VariableTracker implements AdapterCapabilities {

src/plugin/adapter-registry/amalgamator-gdb-tracker.ts

@@ -57,6 +57,10 @@ export class AmalgamatorSessionManager extends VariableTracker implements Adapte
     async getCurrentContext(session: vscode.DebugSession): Promise<Context | undefined> {
         return this.sessions.get(session.id)?.getCurrentContext?.(session);
     }
+
+    supportShowVariables(_session: vscode.DebugSession): boolean {
+        return false;
+    }
 }
 
 export class AmalgamatorGdbVariableTransformer extends AdapterVariableTracker {

src/plugin/memory-provider.ts

@@ -30,6 +30,7 @@ export interface LabeledUint8Array extends Uint8Array {
 export class MemoryProvider {
     public static ReadKey = `${manifest.PACKAGE_NAME}.canRead`;
     public static WriteKey = `${manifest.PACKAGE_NAME}.canWrite`;
+    public static ReadVariableKey = `${manifest.PACKAGE_NAME}.canReadVariable`;
 
     private _onDidStopDebug = new vscode.EventEmitter<vscode.DebugSession>();
     public readonly onDidStopDebug = this._onDidStopDebug.event;
@@ -105,17 +106,20 @@ export class MemoryProvider {
     createContext(session = vscode.debug.activeDebugSession): SessionContext {
         const sessionId = session?.id;
         const capabilities = sessionId ? this.sessionDebugCapabilities.get(sessionId) : undefined;
+        const canReadVariable = this.supportShowVariables();
         return {
             sessionId,
             canRead: !!capabilities?.supportsReadMemoryRequest,
-            canWrite: !!capabilities?.supportsWriteMemoryRequest
+            canWrite: !!capabilities?.supportsWriteMemoryRequest,
+            canReadVariable: !!capabilities?.supportsReadMemoryRequest && !!canReadVariable
         };
     }
 
     protected setContext(session?: vscode.DebugSession): void {
         const newContext = this.createContext(session);
         vscode.commands.executeCommand('setContext', MemoryProvider.ReadKey, newContext.canRead);
         vscode.commands.executeCommand('setContext', MemoryProvider.WriteKey, newContext.canWrite);
+        vscode.commands.executeCommand('setContext', MemoryProvider.ReadVariableKey, newContext.canReadVariable);
         this._onDidChangeSessionContext.fire(newContext);
     }
 
@@ -206,4 +210,10 @@ export class MemoryProvider {
         const handler = this.adapterRegistry?.getHandlerForSession(session.type);
         return handler?.getCurrentContext?.(session);
     }
+
+    public supportShowVariables(): boolean {
+        const session = this.assertActiveSession('supports show variables');
+        const handler = this.adapterRegistry?.getHandlerForSession(session.type);
+        return handler?.supportShowVariables?.(session) ?? true;
+    }
 }

src/webview/memory-webview-view.tsx

@@ -71,7 +71,8 @@ export interface MemoryAppState extends MemoryState, MemoryDisplayConfiguration
 
 const DEFAULT_SESSION_CONTEXT: SessionContext = {
     canRead: false,
-    canWrite: false
+    canWrite: false,
+    canReadVariable: false
 };
 
 const MEMORY_DISPLAY_CONFIGURATION_DEFAULTS: MemoryDisplayConfiguration = {