Skip to content

Commit 20f8b5a

Browse files
[CI][workflows] Use node 20 by default
Prepare for node.js 18 EoL and transition to node 20 as default - start using node 20 for jobs like linting, publishing and license check - Add Node 20 and node 22 to the matrix for "build and test" job - (for now) Keep node 18 as part of the "matrix" for "build and test job". We can remove it once officially EoL The plan is to remove node 18 soon, when it's officially EoL. Signed-off-by: Marc Dumais <[email protected]>
1 parent e8d7e1d commit 20f8b5a

File tree

2 files changed

+14
-12
lines changed

2 files changed

+14
-12
lines changed

.github/workflows/ci-cd.yml

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -12,12 +12,12 @@ on:
1212
jobs:
1313

1414
build-test:
15-
name: Build and Test
15+
name: Build and Test (${{ matrix.os }}, node-${{ matrix.node-version }})
1616
runs-on: ${{ matrix.os }}
1717
strategy:
1818
matrix:
1919
os: [ubuntu-latest]
20-
node-version: [18]
20+
node-version: [18,20,22]
2121

2222
steps:
2323
- uses: actions/checkout@v4
@@ -32,19 +32,21 @@ jobs:
3232
run: yarn test
3333
- name: Package as VSCode Extension
3434
run: yarn vsce:package
35-
# Save the extension .vsix file for potential publishing
36-
# in later step (if appropriate)
35+
# Save the extension ().vsix file) for publishing in later step
36+
# (when appropriate)
3737
- uses: actions/upload-artifact@v4
3838
with:
3939
name: extension
4040
path: vscode-trace-server-*.vsix
41+
if: github.event_name == 'release' && startsWith(github.ref, 'refs/tags/v') && github.repository == 'eclipse-cdt-cloud/vscode-trace-server'
4142

4243
code-lint:
44+
name: Run linter (${{ matrix.os }})
4345
runs-on: ${{ matrix.os }}
4446
strategy:
4547
matrix:
4648
os: [ubuntu-latest]
47-
node-version: [18]
49+
node-version: [20]
4850

4951
steps:
5052
- name: Check out Git repository
@@ -61,14 +63,14 @@ jobs:
6163

6264
publish-oxsv:
6365
# https://open-vsx.org/
64-
name: Publish extension to public Open VSX Registry
66+
name: Publish extension to public Open VSX Registry (${{ matrix.os }})
6567
runs-on: ${{ matrix.os }}
6668
needs:
6769
- build-test
6870
strategy:
6971
matrix:
7072
os: [ubuntu-latest]
71-
node-version: [18]
73+
node-version: [20]
7274
# Only execute when the trigger was a tag (new release)
7375
if: github.event_name == 'release' && startsWith(github.ref, 'refs/tags/v') && github.repository == 'eclipse-cdt-cloud/vscode-trace-server'
7476

@@ -94,14 +96,14 @@ jobs:
9496

9597
publish-vs-marketplace:
9698
# https://marketplace.visualstudio.com/
97-
name: Publish extension to Visual Studio Marketplace
99+
name: Publish extension to Visual Studio Marketplace (${{ matrix.os }})
98100
runs-on: ${{ matrix.os }}
99101
needs:
100102
- build-test
101103
strategy:
102104
matrix:
103105
os: [ubuntu-latest]
104-
node-version: [18]
106+
node-version: [20]
105107
# Only execute when the trigger was a tag (new release)
106108
if: github.event_name == 'release' && startsWith(github.ref, 'refs/tags/v') && github.repository == 'eclipse-cdt-cloud/vscode-trace-server'
107109

.github/workflows/license-check-workflow.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,13 +14,13 @@ on:
1414
jobs:
1515

1616
License-check:
17-
name: 3PP License Check using dash-licenses
17+
name: 3PP License Check using dash-licenses (${{ matrix.os }})
1818

1919
strategy:
2020
fail-fast: false
2121
matrix:
2222
os: [ubuntu-latest]
23-
node: [18]
23+
node-version: [20]
2424
java: [11]
2525

2626
runs-on: ${{ matrix.os }}
@@ -35,7 +35,7 @@ jobs:
3535
- name: Use Node.js ${{ matrix.node }}
3636
uses: actions/setup-node@v4
3737
with:
38-
node-version: ${{ matrix.node }}
38+
node-version: ${{ matrix.node-version }}
3939

4040
- name: Use Java ${{ matrix.java }}
4141
uses: actions/setup-java@v3

0 commit comments

Comments
 (0)