Fix stopping trace server during shutdown

Fixes #13

Signed-off-by: Bernd Hufmann <[email protected]>

Author: bhufmann

src/extension.ts

@@ -14,8 +14,8 @@ export function activate(context: vscode.ExtensionContext) {
     activation = context;
 }
 
-export function deactivate() {
-    server.stopOrReset(activation);
+export async function deactivate() {
+    await server.shutdown(activation);
 }
 
 function registerStopOrReset(context: vscode.ExtensionContext | undefined): vscode.Disposable {

src/trace-server.ts

@@ -13,6 +13,7 @@ const millis = 10000;
 const none = -1;
 const prefix = 'Trace Server';
 const suffix = ' failure or so.';
+const SHUTDOWN_DELAY = 2000;
 
 export class TraceServer {
     private server: ChildProcess | undefined;
@@ -71,6 +72,24 @@ export class TraceServer {
         this.server = undefined;
     }
 
+    async shutdown(context: vscode.ExtensionContext) {
+        // Take the pid from the server instead from workspace state because
+        // during shutdown the workspace can't be queried anymore
+        const pid = this.server ? this.server.pid : undefined;
+        if (!pid) {
+            return;
+        }
+        if (pid) {
+            treeKill(pid);
+            // Allow the treeKill to finish collecting and killing all
+            // spawned processes.
+            await new Promise(resolve => setTimeout(resolve, SHUTDOWN_DELAY));
+
+            // Try to reset pid in workspace state
+            await context?.workspaceState.update(key, none);
+        }
+    }
+
     async startIfStopped(context: vscode.ExtensionContext | undefined) {
         const pid = context?.workspaceState.get(key);
         const stopped = !pid || pid === none;